feat(graphqlmetrics): enable prometheus metrics #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- decouples router from graphqlmetrics - enables using new version of the middleware instrumentation
…5-instrument-graphqlmetrics-collector-with-metrics
AndreasZeissner
changed the title
…5-instrument-graphqlmetrics-collector-with-metrics
StarpTech
requested changes
Jul 26, 2024
…5-instrument-graphqlmetrics-collector-with-metrics
* avoids handling mocks * the prometheus server is currently started seperatley in the main func logic it can't start when it was not constructed in the first place
This was referenced Aug 7, 2024
Closed
Closed
Closed
Closed
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR introduces exposing metrics on the graphqlmetrics service.
The prometheus export can be enabled by using the following environment variables:
PROMETHEUS_ENABLED: enable or disable exposing metrics defaults to falsePROMETHEUS_LISTEN_ADDR: the listen address for the prometheus server defaults to 127.0.0.1:8088 to exposing metrics to the public bt accidentPROMETHEUS_PATH: the path to expose the metrics on defaults to /metricsTODO