Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor federation factory #595

Merged
merged 10 commits into from
Mar 6, 2024
Merged

chore: refactor federation factory #595

merged 10 commits into from
Mar 6, 2024

Conversation

Aenimus
Copy link
Member

@Aenimus Aenimus commented Mar 2, 2024

Motivation and Context

TODO

@Aenimus Aenimus marked this pull request as ready for review March 4, 2024 23:56
@Aenimus Aenimus changed the title chore: refactor federation factory (WIP) chore: refactor federation factory Mar 5, 2024
@Aenimus Aenimus requested a review from StarpTech March 5, 2024 09:09
@Aenimus Aenimus marked this pull request as draft March 5, 2024 19:04
StarpTech
StarpTech requested changes Mar 6, 2024
View reviewed changes
studio/package.json Show resolved Hide resolved
composition/src/normalization/normalization-factory.ts Show resolved Hide resolved
composition/src/normalization/normalization-factory.ts Show resolved Hide resolved
composition/src/schema-building/ast.ts Outdated Show resolved Hide resolved
@Aenimus Aenimus marked this pull request as ready for review March 6, 2024 14:28
@Aenimus Aenimus requested a review from StarpTech March 6, 2024 14:40
StarpTech
StarpTech approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aenimus Aenimus merged commit 020d30e into main Mar 6, 2024
15 checks passed
PeteMac88 pushed a commit to gastromatic/cosmo that referenced this pull request Mar 11, 2024
@Aenimus @PeteMac88
chore: refactor federation factory (wundergraph#595)
3f728d3
@jiajun-brex jiajun-brex mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

@JivusAyrus JivusAyrus Awaiting requested review from JivusAyrus

@devsergiy devsergiy Awaiting requested review from devsergiy

@thisisnithin thisisnithin Awaiting requested review from thisisnithin

@jensneuse jensneuse Awaiting requested review from jensneuse

Assignees
No one assigned
Labels
controlplane monorepo studio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aenimus @StarpTech