fix(docs): enhance PQL manifest documentation for clarity and detail#2734
fix(docs): enhance PQL manifest documentation for clarity and detail#2734
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
WalkthroughUpdated documentation and JSON schema to clarify persisted operations manifest file configuration. Added a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
docs-website/router/persisted-queries/persisted-operations.mdx (1)
121-121: Consider splitting the sentence for improved clarity.The sentence packs multiple ideas into one complex structure. As per coding guidelines: "Prefer short, declarative sentences. If a sentence has more than one comma-separated clause, consider splitting it."
✨ Optional refinement for clarity
-By default, the router fetches persisted operations individually from the Cosmo CDN on each request. When the **PQL manifest** is enabled, the router instead loads all persisted operations from a single manifest file at startup and serves them entirely from memory, eliminating per-request network overhead. +By default, the router fetches persisted operations individually from the Cosmo CDN on each request. When the **PQL manifest** is enabled, the router loads all persisted operations from a single manifest file at startup. Operations are served entirely from memory, eliminating per-request network overhead.Based on learnings, As per coding guidelines: "Prefer short, declarative sentences. If a sentence has more than one comma-separated clause, consider splitting it."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs-website/router/persisted-queries/persisted-operations.mdx` at line 121, The paragraph describing persisted operations is a long sentence that combines multiple ideas; split it into two short, declarative sentences: one stating the default behavior (“By default, the router fetches persisted operations individually from the Cosmo CDN on each request.”) and a second explaining the alternative when the PQL manifest is enabled (“When the PQL manifest is enabled, the router loads all persisted operations from a single manifest file at startup and serves them entirely from memory, eliminating per-request network overhead.”). Update the sentence that mentions the PQL manifest and persisted operations to follow this split so each clause is its own clear sentence.docs-website/router/configuration.mdx (1)
1178-1179: Split these descriptions into short factual sentences for readability.Both cells pack several behaviors into long clauses. Breaking them into short statements will match the doc style guide and make the table easier to scan.
Proposed rewrite
-| PERSISTED_OPERATIONS_MANIFEST_ENABLED | persisted_operations.manifest.enabled | <Icon icon="square" /> | Enable the PQL manifest. When enabled, the router loads all persisted operations from a single manifest file and serves them from memory. Uses the `storage` config above when a provider is set, otherwise fetches from the Cosmo CDN. Only S3 and CDN storage providers are supported. | false | -| PERSISTED_OPERATIONS_MANIFEST_FILE_NAME | persisted_operations.manifest.file_name | <Icon icon="square" /> | The manifest file name. Only used when a custom storage provider is configured. The router resolves the full object path as `<object_prefix>/<file_name>`. Use a `.gz` or `.zst` extension (e.g. `manifest.json.gz`) to enable transparent decompression. Ignored in CDN mode. | manifest.json | +| PERSISTED_OPERATIONS_MANIFEST_ENABLED | persisted_operations.manifest.enabled | <Icon icon="square" /> | Enable the PQL manifest. The router loads persisted operations from one manifest file and serves them from memory. If a storage provider is set, the router uses `persisted_operations.storage`. If no provider is set, the router fetches from the Cosmo CDN. Supported providers are S3 and CDN. | false | +| PERSISTED_OPERATIONS_MANIFEST_FILE_NAME | persisted_operations.manifest.file_name | <Icon icon="square" /> | Manifest file name. Used only with a custom storage provider. The router resolves the object path as `<object_prefix>/<file_name>`. `.gz` and `.zst` extensions (for example `manifest.json.gz`) enable transparent decompression. Ignored in CDN mode. | manifest.json |As per coding guidelines: "Prefer short, declarative sentences. If a sentence has more than one comma-separated clause, consider splitting it." and "Use structured lists when presenting multiple distinct items. Do not pack them into a single paragraph."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs-website/router/configuration.mdx` around lines 1178 - 1179, Split the long table descriptions for PERSISTED_OPERATIONS_MANIFEST_ENABLED and PERSISTED_OPERATIONS_MANIFEST_FILE_NAME into short, declarative sentences: for PERSISTED_OPERATIONS_MANIFEST_ENABLED (persisted_operations.manifest.enabled) break into separate sentences stating that it enables the PQL manifest, that when enabled the router loads persisted operations from a single manifest file and serves them from memory, that it uses the configured storage provider when set otherwise fetches from the Cosmo CDN, and that only S3 and CDN providers are supported; for PERSISTED_OPERATIONS_MANIFEST_FILE_NAME (persisted_operations.manifest.file_name) split into sentences stating it is the manifest file name, that it is only used with a custom storage provider, how the router resolves the full object path (<object_prefix>/<file_name>), the note about using .gz or .zst to enable transparent decompression, and that it is ignored in CDN mode.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs-website/router/configuration.mdx`:
- Around line 1178-1179: Split the long table descriptions for
PERSISTED_OPERATIONS_MANIFEST_ENABLED and
PERSISTED_OPERATIONS_MANIFEST_FILE_NAME into short, declarative sentences: for
PERSISTED_OPERATIONS_MANIFEST_ENABLED (persisted_operations.manifest.enabled)
break into separate sentences stating that it enables the PQL manifest, that
when enabled the router loads persisted operations from a single manifest file
and serves them from memory, that it uses the configured storage provider when
set otherwise fetches from the Cosmo CDN, and that only S3 and CDN providers are
supported; for PERSISTED_OPERATIONS_MANIFEST_FILE_NAME
(persisted_operations.manifest.file_name) split into sentences stating it is the
manifest file name, that it is only used with a custom storage provider, how the
router resolves the full object path (<object_prefix>/<file_name>), the note
about using .gz or .zst to enable transparent decompression, and that it is
ignored in CDN mode.
In `@docs-website/router/persisted-queries/persisted-operations.mdx`:
- Line 121: The paragraph describing persisted operations is a long sentence
that combines multiple ideas; split it into two short, declarative sentences:
one stating the default behavior (“By default, the router fetches persisted
operations individually from the Cosmo CDN on each request.”) and a second
explaining the alternative when the PQL manifest is enabled (“When the PQL
manifest is enabled, the router loads all persisted operations from a single
manifest file at startup and serves them entirely from memory, eliminating
per-request network overhead.”). Update the sentence that mentions the PQL
manifest and persisted operations to follow this split so each clause is its own
clear sentence.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 86372e7f-de40-4fb2-b2e5-b258cfafd396
📒 Files selected for processing (3)
docs-website/router/configuration.mdxdocs-website/router/persisted-queries/persisted-operations.mdxrouter/pkg/config/config.schema.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2734 +/- ##
==========================================
- Coverage 63.24% 63.19% -0.05%
==========================================
Files 251 251
Lines 26763 26763
==========================================
- Hits 16925 16913 -12
- Misses 8460 8470 +10
- Partials 1378 1380 +2 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
New Features
PERSISTED_OPERATIONS_MANIFEST_FILE_NAME), allowing customization of the manifest filename with support for compression extensions.Documentation
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.