Skip to content

feat: configure composeGraphsPool to use child_process runtime#2657

Merged
StarpTech merged 2 commits intomainfrom
dustin/use-child-process-for-pools
Mar 17, 2026
Merged

feat: configure composeGraphsPool to use child_process runtime#2657
StarpTech merged 2 commits intomainfrom
dustin/use-child-process-for-pools

Conversation

@StarpTech
Copy link
Copy Markdown
Contributor

@StarpTech StarpTech commented Mar 17, 2026

Summary by CodeRabbit

  • Chores
    • Updated worker pool configuration to enhance task execution and serialization efficiency.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/docs-website.
  • I have read the Contributors Guide.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b5fb90f9-fb06-468a-affc-a7dca97c82b4

📥 Commits

Reviewing files that changed from the base of the PR and between 66e7bf2 and 3f58ce8.

📒 Files selected for processing (1)
  • controlplane/src/core/composition/composeGraphs.pool.ts

Walkthrough

Adds worker pool configuration properties to the compose graphs pool initialization, specifying child_process runtime and advanced serialization for task handling between threads.

Changes

Cohort / File(s) Summary
Worker Pool Configuration
controlplane/src/core/composition/composeGraphs.pool.ts
Added runtime: 'child_process' and serialization: 'advanced' properties to pool initialization, modifying worker execution and task serialization behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: configuring the composeGraphsPool to use child_process runtime, which directly corresponds to the actual changes made in the pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.21%. Comparing base (66e7bf2) to head (3f58ce8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2657       +/-   ##
===========================================
+ Coverage   46.42%   64.21%   +17.79%     
===========================================
  Files        1046      304      -742     
  Lines      141496    43042    -98454     
  Branches     9683     4604     -5079     
===========================================
- Hits        65690    27640    -38050     
+ Misses      74094    15380    -58714     
+ Partials     1712       22     -1690     
Files with missing lines Coverage Δ
...olplane/src/core/composition/composeGraphs.pool.ts 81.81% <100.00%> (+0.42%) ⬆️

... and 742 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StarpTech StarpTech merged commit 76c16ce into main Mar 17, 2026
13 checks passed
@StarpTech StarpTech deleted the dustin/use-child-process-for-pools branch March 17, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants