feat: bump graphql-go-tools to v2.0.0-rc.252, add gRPC header forwarding and nil context guard#2535
Closed
feat: bump graphql-go-tools to v2.0.0-rc.252, add gRPC header forwarding and nil context guard#2535
Conversation
… forwarding and nil context guard Bump graphql-go-tools/v2 from rc.251 to rc.252 which adds gRPC header forwarding (PR #1382), fixes flaky singleflight tests (PR #1393), and guards against nil loaderHookContext on skipped fetches (PR #1394). Router-side changes: - Add defensive nil guard in getResponseHeaderPropagation to prevent panic when OnFinished is called with nil context (fixes #2530) - Add isIgnoredHeader() with Grpc- prefix filtering to prevent reserved gRPC headers from being forwarded to any subgraph - Add GRPCInterceptor support to testenv for verifying gRPC metadata Integration tests: - 6 tests for gRPC header forwarding as metadata (named, excluded, multi-value, unsafe filtered, grpc-reserved blocked, safe headers) - 2 tests for null-parent skipped-fetch scenarios with and without response header propagation (reproduces #2530) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jensneuse
requested review from
Noroth,
StarpTech,
devsergiy and
endigma
as code owners
Contributor
jensneuse
changed the title
❌ Internal Query Planner CI checks failedThe Internal Query Planner CI checks failed in the celestial repository, and this is going to stop the merge of this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
+ Coverage 61.00% 61.47% +0.46%
==========================================
Files 239 239
Lines 25416 25425 +9
==========================================
+ Hits 15506 15630 +124
+ Misses 8589 8479 -110
+ Partials 1321 1316 -5
🚀 New features to boost your workflow:
|
dkorittki
added a commit
that referenced
this pull request
Feb 19, 2026
This has been taking from another PR so we can close that one #2535
Contributor
|
fyi changes from here have been incorporated into #2524. This happened in agreement with @jensneuse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Bumps `graphql-go-tools` to v2.0.0-rc.252. Adds HTTP→gRPC metadata header forwarding: headers matching propagation rules are forwarded to gRPC subgraph calls, with unsafe/reserved headers (`grpc-*`, hop-by-hop, content-negotiation, WebSocket) automatically excluded. Also fixes a nil-context panic in `getResponseHeaderPropagation` that occurred when a parent entity is null and a downstream fetch is skipped (issue #2530).
Checklist