-
Notifications
You must be signed in to change notification settings - Fork 201
feat: mask hostname in cli telemetry #2416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: mask hostname in cli telemetry #2416
Conversation
WalkthroughTelemetry now computes a deterministic Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4509569 to
499ad6d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
===========================================
- Coverage 42.59% 28.67% -13.93%
===========================================
Files 1013 127 -886
Lines 141063 11059 -130004
Branches 8660 241 -8419
===========================================
- Hits 60086 3171 -56915
+ Misses 79365 7886 -71479
+ Partials 1612 2 -1610 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cli/src/core/telemetry.ts(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
cli/src/core/telemetry.ts (1)
cli/src/core/config.ts (1)
config(23-38)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
cli/src/core/telemetry.ts (1)
161-161: Good privacy improvement.Using the hashed machine_id instead of the raw hostname is the right approach for protecting user privacy in telemetry data. The implementation correctly applies the hashed value.
a44082f to
e246f3b
Compare
e246f3b to
20eeabb
Compare
StarpTech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist