-
Notifications
You must be signed in to change notification settings - Fork 205
fix: codecov carryforward paths are not detected #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated a GitHub Actions workflow step label and revised the repository Codecov config: standardized flag paths to directory-style entries with trailing slashes, adjusted composition carryforward, and added comment-related configuration keys (layout/behavior/requirements). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/protographic.yaml(1 hunks)codecov.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
codecov.yaml
[error] 46-46: syntax error: found unexpected end of stream
(syntax)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
.github/workflows/protographic.yaml (1)
44-51: Step label clarification looks good.The label change from "Upload integration results to Codecov" to "Upload test results to Codecov" better reflects the actual content being uploaded. Action parameters and inputs remain unchanged.
codecov.yaml (1)
17-17: Standardized flag paths with trailing slashes for carryforward detection.The addition of trailing slashes (router/, cli/, studio/, etc.) standardizes the path format for directory-style matching, which should improve Codecov's ability to detect and match paths during carryforward. This aligns with the PR objective.
Please verify that these standardized paths are correctly recognized by Codecov's carryforward feature in your test environment.
Also applies to: 21-21, 25-25, 29-29, 33-33, 37-37
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
===========================================
+ Coverage 62.28% 90.55% +28.26%
===========================================
Files 295 16 -279
Lines 41153 3271 -37882
Branches 4194 871 -3323
===========================================
- Hits 25632 2962 -22670
+ Misses 15501 309 -15192
+ Partials 20 0 -20 🚀 New features to boost your workflow:
|
…ueries (wundergraph#2411) chore(release): Publish [skip ci] - wgc@0.102.5 - @wundergraph/composition@0.49.0 - controlplane@0.181.0 - graphqlmetrics@0.37.0 - @wundergraph/protographic@0.14.0 - router@0.273.0 - @wundergraph/cosmo-shared@0.42.24 - studio@0.147.0 feat: upgrade NextJS (wundergraph#2410) chore(release): Publish [skip ci] - studio@0.148.0 fix: resolve js-yaml vulnerabilities (wundergraph#2415) feat: validate session cookie (wundergraph#2406) Co-authored-by: Milinda Dias <83293842+SkArchon@users.noreply.github.com> chore(release): Publish [skip ci] - wgc@0.102.6 - controlplane@0.182.0 - keycloak@0.11.1 fix: codecov carryforward paths are not detected (wundergraph#2412) chore: bumping expr dependency (wundergraph#2419) fix: make error accessible to custom modules (wundergraph#2420) chore(release): Publish [skip ci] - router@0.273.1 fix: use the correct cgroup policy to work on most of the systems (wundergraph#2421) chore(release): Publish [skip ci] - router@0.273.2 Add support for per message deflate to websocket connectinos Merge branch 'main' into per-message-deflate revert formatting
…ueries (wundergraph#2411) chore(release): Publish [skip ci] - wgc@0.102.5 - @wundergraph/composition@0.49.0 - controlplane@0.181.0 - graphqlmetrics@0.37.0 - @wundergraph/protographic@0.14.0 - router@0.273.0 - @wundergraph/cosmo-shared@0.42.24 - studio@0.147.0 feat: upgrade NextJS (wundergraph#2410) chore(release): Publish [skip ci] - studio@0.148.0 fix: resolve js-yaml vulnerabilities (wundergraph#2415) feat: validate session cookie (wundergraph#2406) Co-authored-by: Milinda Dias <83293842+SkArchon@users.noreply.github.com> chore(release): Publish [skip ci] - wgc@0.102.6 - controlplane@0.182.0 - keycloak@0.11.1 fix: codecov carryforward paths are not detected (wundergraph#2412) chore: bumping expr dependency (wundergraph#2419) fix: make error accessible to custom modules (wundergraph#2420) chore(release): Publish [skip ci] - router@0.273.1 fix: use the correct cgroup policy to work on most of the systems (wundergraph#2421) chore(release): Publish [skip ci] - router@0.273.2 Add support for per message deflate to websocket connectinos Merge branch 'main' into per-message-deflate revert formatting
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Checklist