Skip to content

fix: propagate @openfed__requireFetchReasons on Interfaces #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2025
+668 −386
Merged

fix: propagate @openfed__requireFetchReasons on Interfaces #2256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b13fba
fix: propagate @openfed__requireFetchReasons on Interfaces
Aenimus Oct 2, 2025
25bd1e3
Merge branch 'main' into david/eng-8262-propagate-interface-fetch-rea…
ysmolski Oct 9, 2025
9803be4
chore: respond to PR feedback
Aenimus Oct 10, 2025
f0c33ee
chore: respond to PR feedback
Aenimus Oct 10, 2025
8d00e70
Merge branch 'main' into david/eng-8262-propagate-interface-fetch-rea…
Aenimus Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
296 changes: 148 additions & 148 deletions composition-go/index.global.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions composition/src/ast/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,3 +289,7 @@ export type ObjectTypeNode = ObjectTypeDefinitionNode | ObjectTypeExtensionNode;
export type ScalarTypeNode = ScalarTypeDefinitionNode | ScalarTypeExtensionNode;
export type SchemaNode = SchemaDefinitionNode | SchemaExtensionNode;
export type UnionTypeNode = UnionTypeDefinitionNode | UnionTypeExtensionNode;

export type InterfaceNodeKind = Kind.INTERFACE_TYPE_DEFINITION | Kind.INTERFACE_TYPE_EXTENSION;
export type ObjectNodeKind = Kind.OBJECT_TYPE_DEFINITION | Kind.OBJECT_TYPE_EXTENSION;
export type CompositeOutputNodeKind = InterfaceNodeKind | ObjectNodeKind;
155 changes: 78 additions & 77 deletions composition/src/schema-building/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
import { FieldSetConditionData } from '../router-configuration/types';
import { KeyFieldSetData } from '../v1/normalization/types';
import { InputNodeKind, OutputNodeKind } from '../utils/types';
import { FieldName, SubgraphName } from '../types/types';
import { DirectiveName, FieldName, SubgraphName, TypeName } from '../types/types';

export type ArgumentData = {
name: string;
Expand All @@ -39,7 +39,7 @@ export type ConfigureDescriptionData = {
};

export type DirectiveDefinitionData = {
argumentTypeNodeByArgumentName: Map<string, ArgumentData>;
argumentTypeNodeByName: Map<string, ArgumentData>;
isRepeatable: boolean;
locations: Set<string>;
name: string;
Expand All @@ -57,30 +57,30 @@ export enum ExtensionType {

export type EnumDefinitionData = {
appearances: number;
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
enumValueDataByValueName: Map<string, EnumValueData>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
enumValueDataByName: Map<string, EnumValueData>;
extensionType: ExtensionType;
isInaccessible: boolean;
kind: Kind.ENUM_TYPE_DEFINITION;
name: string;
node: MutableEnumNode;
persistedDirectivesData: PersistedDirectivesData;
subgraphNames: Set<string>;
subgraphNames: Set<SubgraphName>;
description?: StringValueNode;
};

export type EnumValueData = {
appearances: number;
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
federatedCoords: string;
kind: Kind.ENUM_VALUE_DEFINITION;
name: string;
node: MutableEnumValueNode;
parentTypeName: string;
parentTypeName: TypeName;
persistedDirectivesData: PersistedDirectivesData;
subgraphNames: Set<string>;
subgraphNames: Set<SubgraphName>;
description?: StringValueNode;
};

Expand All @@ -96,145 +96,146 @@ export type ExternalFieldData = {

export type FieldData = {
argumentDataByName: Map<string, InputValueData>;
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
externalFieldDataBySubgraphName: Map<string, ExternalFieldData>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
externalFieldDataBySubgraphName: Map<SubgraphName, ExternalFieldData>;
federatedCoords: string;
inheritedDirectiveNames: Set<string>;
inheritedDirectiveNames: Set<DirectiveName>;
isInaccessible: boolean;
isShareableBySubgraphName: Map<SubgraphName, boolean>;
kind: Kind.FIELD_DEFINITION;
name: string;
name: FieldName;
namedTypeKind: OutputNodeKind | Kind.NULL;
namedTypeName: string;
namedTypeName: TypeName;
node: MutableFieldNode;
nullLevelsBySubgraphName: Map<SubgraphName, Set<number>>;
originalParentTypeName: string;
originalParentTypeName: TypeName;
persistedDirectivesData: PersistedDirectivesData;
renamedParentTypeName: string;
renamedParentTypeName: TypeName;
subgraphNames: Set<SubgraphName>;
type: MutableTypeNode;
description?: StringValueNode;
};

export type InputObjectDefinitionData = {
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
extensionType: ExtensionType;
inputValueDataByName: Map<string, InputValueData>;
inputValueDataByName: Map<FieldName, InputValueData>;
isInaccessible: boolean;
kind: Kind.INPUT_OBJECT_TYPE_DEFINITION;
name: string;
name: TypeName;
node: MutableInputObjectNode;
persistedDirectivesData: PersistedDirectivesData;
subgraphNames: Set<string>;
subgraphNames: Set<SubgraphName>;
description?: StringValueNode;
};

export type InputValueData = {
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
federatedCoords: string;
includeDefaultValue: boolean;
isArgument: boolean;
kind: Kind.ARGUMENT | Kind.INPUT_VALUE_DEFINITION;
name: string;
name: FieldName;
namedTypeKind: InputNodeKind | Kind.NULL;
namedTypeName: string;
namedTypeName: TypeName;
node: MutableInputValueNode;
originalCoords: string;
originalParentTypeName: string;
originalParentTypeName: TypeName;
persistedDirectivesData: PersistedDirectivesData;
renamedParentTypeName: string;
requiredSubgraphNames: Set<string>;
subgraphNames: Set<string>;
renamedParentTypeName: TypeName;
requiredSubgraphNames: Set<SubgraphName>;
subgraphNames: Set<SubgraphName>;
type: MutableTypeNode;
defaultValue?: ConstValueNode;
description?: StringValueNode;
fieldName?: string;
fieldName?: FieldName;
};

export type InterfaceDefinitionData = {
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
extensionType: ExtensionType;
fieldDataByName: Map<string, FieldData>;
implementedInterfaceTypeNames: Set<string>;
fieldDataByName: Map<FieldName, FieldData>;
implementedInterfaceTypeNames: Set<TypeName>;
isEntity: boolean;
isInaccessible: boolean;
kind: Kind.INTERFACE_TYPE_DEFINITION;
name: string;
name: TypeName;
node: MutableInterfaceNode;
persistedDirectivesData: PersistedDirectivesData;
subgraphNames: Set<string>;
requireFetchReasonsFieldNames: Set<FieldName>;
subgraphNames: Set<SubgraphName>;
description?: StringValueNode;
};

export type ObjectDefinitionData = {
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
extensionType: ExtensionType;
fieldDataByName: Map<FieldName, FieldData>;
implementedInterfaceTypeNames: Set<string>;
implementedInterfaceTypeNames: Set<TypeName>;
isEntity: boolean;
isInaccessible: boolean;
isRootType: boolean;
kind: Kind.OBJECT_TYPE_DEFINITION;
name: string;
name: TypeName;
node: MutableObjectNode;
persistedDirectivesData: PersistedDirectivesData;
renamedTypeName: string;
renamedTypeName: TypeName;
requireFetchReasonsFieldNames: Set<FieldName>;
subgraphNames: Set<string>;
subgraphNames: Set<SubgraphName>;
description?: StringValueNode;
};

export type PersistedDirectiveDefinitionData = {
argumentDataByArgumentName: Map<string, InputValueData>;
argumentDataByName: Map<string, InputValueData>;
executableLocations: Set<string>;
name: string;
name: DirectiveName;
repeatable: boolean;
subgraphNames: Set<string>;
subgraphNames: Set<SubgraphName>;
description?: StringValueNode;
};

export type PersistedDirectivesData = {
deprecatedReason: string;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
isDeprecated: boolean;
tagDirectiveByName: Map<string, ConstDirectiveNode>;
};

export type ScalarDefinitionData = {
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
extensionType: ExtensionType;
kind: Kind.SCALAR_TYPE_DEFINITION;
name: string;
name: TypeName;
node: MutableScalarNode;
persistedDirectivesData: PersistedDirectivesData;
subgraphNames: Set<string>;
subgraphNames: Set<SubgraphName>;
description?: StringValueNode;
};

export type SchemaData = {
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
kind: Kind.SCHEMA_DEFINITION;
name: string;
operationTypes: Map<OperationTypeNode, OperationTypeDefinitionNode>;
description?: StringValueNode;
};

export type UnionDefinitionData = {
configureDescriptionDataBySubgraphName: Map<string, ConfigureDescriptionData>;
directivesByDirectiveName: Map<string, Array<ConstDirectiveNode>>;
configureDescriptionDataBySubgraphName: Map<SubgraphName, ConfigureDescriptionData>;
directivesByDirectiveName: Map<DirectiveName, Array<ConstDirectiveNode>>;
extensionType: ExtensionType;
kind: Kind.UNION_TYPE_DEFINITION;
name: string;
memberByMemberTypeName: Map<string, NamedTypeNode>;
name: TypeName;
memberByMemberTypeName: Map<TypeName, NamedTypeNode>;
node: MutableUnionNode;
persistedDirectivesData: PersistedDirectivesData;
subgraphNames: Set<string>;
subgraphNames: Set<SubgraphName>;
description?: StringValueNode;
};

Expand Down Expand Up @@ -268,28 +269,28 @@ export type EntityData = {
// If propagated in documentNodeByKeyFieldSet, at least one subgraph defines a resolvable key with this field set.
documentNodeByKeyFieldSet: Map<string, DocumentNode>;
keyFieldSets: Set<string>;
keyFieldSetDatasBySubgraphName: Map<string, Map<string, KeyFieldSetData>>;
subgraphNames: Set<string>;
typeName: string;
keyFieldSetDatasBySubgraphName: Map<SubgraphName, Map<string, KeyFieldSetData>>;
subgraphNames: Set<SubgraphName>;
typeName: TypeName;
};

export type SimpleFieldData = {
name: string;
namedTypeName: string;
name: FieldName;
namedTypeName: TypeName;
};

export type EntityInterfaceSubgraphData = {
concreteTypeNames: Set<string>;
concreteTypeNames: Set<TypeName>;
fieldDatas: Array<SimpleFieldData>;
interfaceFieldNames: Set<string>;
interfaceObjectFieldNames: Set<string>;
interfaceFieldNames: Set<FieldName>;
interfaceObjectFieldNames: Set<FieldName>;
isInterfaceObject: boolean;
resolvable: boolean;
typeName: string;
typeName: TypeName;
};

export type FieldAuthorizationData = {
fieldName: string;
fieldName: FieldName;
inheritedData: InheritedAuthorizationData;
originalData: OriginalAuthorizationData;
};
Expand All @@ -306,11 +307,11 @@ export type OriginalAuthorizationData = {
};

export type AuthorizationData = {
fieldAuthDataByFieldName: Map<string, FieldAuthorizationData>;
fieldAuthDataByFieldName: Map<FieldName, FieldAuthorizationData>;
requiredScopes: Array<Set<string>>;
requiredScopesByOR: Array<Set<string>>;
requiresAuthentication: boolean;
typeName: string;
typeName: TypeName;
};

export type ConditionalFieldData = {
Expand All @@ -319,11 +320,11 @@ export type ConditionalFieldData = {
};

export type EntityInterfaceFederationData = {
concreteTypeNames: Set<string>;
fieldDatasBySubgraphName: Map<string, Array<SimpleFieldData>>;
interfaceFieldNames: Set<string>;
interfaceObjectFieldNames: Set<string>;
interfaceObjectSubgraphs: Set<string>;
subgraphDataByTypeName: Map<string, EntityInterfaceSubgraphData>;
typeName: string;
concreteTypeNames: Set<TypeName>;
fieldDatasBySubgraphName: Map<SubgraphName, Array<SimpleFieldData>>;
interfaceFieldNames: Set<FieldName>;
interfaceObjectFieldNames: Set<FieldName>;
interfaceObjectSubgraphNames: Set<SubgraphName>;
subgraphDataByTypeName: Map<TypeName, EntityInterfaceSubgraphData>;
typeName: TypeName;
};
Loading
Loading