Skip to content

fix: improve batching behavior in the dataloader #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+6 −6
Closed

fix: improve batching behavior in the dataloader #2174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72bf055
chore: bump engine version
Noroth Aug 28, 2025
0a1e086
Merge branch 'main' of github.com:wundergraph/cosmo into ludwig/eng-7…
Noroth Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion router-tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ require (
github.com/wundergraph/cosmo/demo/pkg/subgraphs/projects v0.0.0-20250715110703-10f2e5f9c79e
github.com/wundergraph/cosmo/router v0.0.0-20250820135159-bf8852195d3f
github.com/wundergraph/cosmo/router-plugin v0.0.0-20250808194725-de123ba1c65e
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.222
go.opentelemetry.io/otel v1.36.0
go.opentelemetry.io/otel/sdk v1.36.0
go.opentelemetry.io/otel/sdk/metric v1.36.0
Expand Down
4 changes: 2 additions & 2 deletions router-tests/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,8 @@ github.com/wundergraph/astjson v0.0.0-20250106123708-be463c97e083 h1:8/D7f8gKxTB
github.com/wundergraph/astjson v0.0.0-20250106123708-be463c97e083/go.mod h1:eOTL6acwctsN4F3b7YE+eE2t8zcJ/doLm9sZzsxxxrE=
github.com/wundergraph/consul/sdk v0.0.0-20250204115147-ed842a8fd301 h1:EzfKHQoTjFDDcgaECCCR2aTePqMu9QBmPbyhqIYOhV0=
github.com/wundergraph/consul/sdk v0.0.0-20250204115147-ed842a8fd301/go.mod h1:wxI0Nak5dI5RvJuzGyiEK4nZj0O9X+Aw6U0tC1wPKq0=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220 h1:+imPYcv+XExZ+ofX5jCxtaA7upeys7uWA7RsTZiTTWE=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220/go.mod h1:DnYY1alnsgzkanSwbFiFIdXKOuf8dHQWQ2P4BzTc6aI=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.222 h1:93fwbI5/AFEATymZZMx0vCcK0+aXFa/vOe89PJyTYWw=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.222/go.mod h1:DnYY1alnsgzkanSwbFiFIdXKOuf8dHQWQ2P4BzTc6aI=
github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1 h1:gEOO8jv9F4OT7lGCjxCBTO/36wtF6j2nSip77qHd4x4=
github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1/go.mod h1:Ohn+xnUBiLI6FVj/9LpzZWtj1/D6lUovWYBkxHVV3aM=
github.com/yosida95/uritemplate/v3 v3.0.2 h1:Ed3Oyj9yrmi9087+NczuL5BwkIc4wvTb5zIM+UJPGz4=
Expand Down
2 changes: 1 addition & 1 deletion router/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ require (
github.com/tidwall/gjson v1.18.0
github.com/tidwall/sjson v1.2.5
github.com/twmb/franz-go v1.16.1
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.222
Copy link

@coderabbitai coderabbitai bot Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Does rc.222 actually contain the “improve dataloader batching” fix? Add proof + tests.

The PR title/objective mentions batching behavior in the dataloader, but the code change is only a dependency bump. Please:

  • Link the graphql-go-tools v2 changelog/commit(s) showing the batching fix introduced between rc.220 → rc.222.
  • Add/extend router integration tests to assert the batching semantics (e.g., requests within N ms get coalesced; cap sizes respected; no starvation).
  • Ensure no stray replace overrides for graphql-go-tools remain.

🏁 Script executed:

#!/bin/bash
# Verify version bumps and stray replaces.
rg -n 'github.com/wundergraph/graphql-go-tools/v2 v2\.0\.0-rc\.222' router/go.mod router-tests/go.mod
rg -nP '^\s*replace\s+github\.com/wundergraph/graphql-go-tools/v2' -n

Length of output: 431

🌐 Web query:

Provide links to release notes/commits in github.com/wundergraph/graphql-go-tools/v2 that describe dataloader batching changes between v2.0.0-rc.220 and v2.0.0-rc.222.

💡 Result:

Here are the relevant GitHub pages (release notes + compare) for v2.0.0-rc.220 → v2.0.0-rc.222 — I couldn't find any commit or release-note text in that range explicitly mentioning “dataloader” or “batching”:

  • v2.0.0-rc.220 release notes. [1]
  • v2.0.0-rc.222 release notes. [2]
  • Compare view (commits between v2.0.0-rc.220 and v2.0.0-rc.222). [3]

If you want, I can scan each commit in the compare and provide direct commit links for any files that touch batching-related code (e.g., packages under v2/pkg/engine/resolve or loader code).

Sources:
[1] https://github.com/wundergraph/graphql-go-tools/releases/tag/v2.0.0-rc.220. (github.com)
[2] https://github.com/wundergraph/graphql-go-tools/releases/tag/v2.0.0-rc.222. (github.com)
[3] wundergraph/graphql-go-tools@v2.0.0-rc.220...v2.0.0-rc.222. (github.com)

Citations:

Link batching fix commit, add tests, remove stray replace

  • No batching fix found in v2.0.0-rc.220→rc.222 release notes or commits–please link the specific commit(s) or changelog entry introducing the dataloader batching improvements.
  • Add/extend integration tests in router to verify dataloader coalescing behavior (batch window timing, max batch size, starvation prevention).
  • Remove the stray replace github.com/wundergraph/graphql-go-tools/v2 => ../../graphql-go-tools/v2 in router/README.md line 33.
🤖 Prompt for AI Agents 
In router/go.mod around line 34, the PR updates graphql-go-tools to
v2.0.0-rc.222 but the review requests (1) add a link to the exact commit or
changelog entry that introduced the dataloader batching fix — update the PR
description or go.mod comment with the commit hash or changelog URL (or add a
short note in router/CHANGELOG.md) referencing the specific commit(s) or release
notes; (2) add/extend router integration tests that assert dataloader coalescing
behavior: write tests covering batch window timing, max batch size enforcement,
and starvation prevention (simulate concurrent requests over time and verify
that requests are batched appropriately and no single request/starvation
occurs); and (3) remove the stray replace line in router/README.md (remove the
line `replace github.com/wundergraph/graphql-go-tools/v2 =>
../../graphql-go-tools/v2` at README.md line 33) so the module uses the intended
module proxy version.

// Do not upgrade, it renames attributes we rely on
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0
go.opentelemetry.io/contrib/propagators/b3 v1.23.0
Expand Down
4 changes: 2 additions & 2 deletions router/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ github.com/wk8/go-ordered-map/v2 v2.1.8 h1:5h/BUHu93oj4gIdvHHHGsScSTMijfx5PeYkE/
github.com/wk8/go-ordered-map/v2 v2.1.8/go.mod h1:5nJHM5DyteebpVlHnWMV0rPz6Zp7+xBAnxjb1X5vnTw=
github.com/wundergraph/astjson v0.0.0-20250106123708-be463c97e083 h1:8/D7f8gKxTBjW+SZK4mhxTTBVpxcqeBgWF1Rfmltbfk=
github.com/wundergraph/astjson v0.0.0-20250106123708-be463c97e083/go.mod h1:eOTL6acwctsN4F3b7YE+eE2t8zcJ/doLm9sZzsxxxrE=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220 h1:+imPYcv+XExZ+ofX5jCxtaA7upeys7uWA7RsTZiTTWE=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.220/go.mod h1:DnYY1alnsgzkanSwbFiFIdXKOuf8dHQWQ2P4BzTc6aI=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.222 h1:93fwbI5/AFEATymZZMx0vCcK0+aXFa/vOe89PJyTYWw=
github.com/wundergraph/graphql-go-tools/v2 v2.0.0-rc.222/go.mod h1:DnYY1alnsgzkanSwbFiFIdXKOuf8dHQWQ2P4BzTc6aI=
github.com/yosida95/uritemplate/v3 v3.0.2 h1:Ed3Oyj9yrmi9087+NczuL5BwkIc4wvTb5zIM+UJPGz4=
github.com/yosida95/uritemplate/v3 v3.0.2/go.mod h1:ILOh0sOhIJR3+L/8afwt/kE++YT040gmv5BQTMR2HP4=
github.com/yuin/gopher-lua v1.1.1 h1:kYKnWBjvbNP4XLT3+bPEwAXJx262OhaHDWDVOPjL46M=
Expand Down
Loading