fix: fix composition wrapper by adding URL.canParse to polyfill

[devsergiy]

Summary by CodeRabbit

• New Features
  • Added a static method to the URL class for checking if a URL can be parsed.
  • Introduced a utility function to validate URL strings.
  • Subgraph test data now includes URL fields for each subgraph.
• Chores
  • Added a Makefile with a test target for improved testing workflows.

Checklist

• I have discussed my proposed changes in an issue and have received approval to proceed.
• I have followed the coding standards of the project.
• Tests or benchmarks have been added or updated.
• Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
• I have read the Contributors Guide.

[coderabbitai]

Walkthrough

A Makefile was introduced for running tests in the composition-go module. The test code was updated to include URLs for subgraphs. A utility for checking URL parse-ability was implemented in Go and exposed to both Goja and V8 JavaScript runtimes, with corresponding static methods added to JavaScript URL classes.

Changes

Cohort / File(s)	Change Summary
Test Infrastructure composition-go/Makefile	Added a Makefile with a test target to run Go tests with and without a build tag.
Test Data Update composition-go/composition_test.go	Added URL field to Subgraph test instances with example URLs.
Go URL Utility composition-go/polyfill.go	Added urlCanParse function to check if a string is a valid URL.
Goja Runtime Integration composition-go/vm_goja.go	Registered urlCanParse as a global function in the Goja VM.
V8 Runtime Integration composition-go/vm_v8.go	Added V8 binding for urlCanParse and registered it as a global function in V8.
JavaScript Polyfills composition-go/index.global.js, composition-go/shim/src/polyfill.js	Added static canParse(url, base) method to the URL class, calling the native urlCanParse.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.38.6)

composition-go/index.global.js

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1597b8d and 0223281.

📒 Files selected for processing (1)

• composition-go/index.global.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• composition-go/index.global.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: build_test
• GitHub Check: build_push_image
• GitHub Check: integration_test (./telemetry)
• GitHub Check: image_scan (nonroot)
• GitHub Check: image_scan
• GitHub Check: build_push_image (nonroot)
• GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
• GitHub Check: integration_test (./events)
• GitHub Check: build_test
• GitHub Check: Analyze (go)
• GitHub Check: Analyze (javascript-typescript)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch sergiy/eng-7748-fix-composition-wrapper

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-cb334f05e98f3c35ee68e066ca26bda75eaf3b01

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

composition-go/composition_test.go (1)

38-38: LGTM! Appropriate test data for URL functionality.

The addition of well-formed HTTPS URLs to the subgraph definitions supports the new URL parsing capabilities.

Consider adding explicit tests for the new URL.canParse functionality to ensure it works correctly with both valid and invalid URLs. Would you like me to help generate test cases for this?

Also applies to: 62-62

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d26c18b and 719dda7.

📒 Files selected for processing (7)

• composition-go/Makefile (1 hunks)
• composition-go/composition_test.go (2 hunks)
• composition-go/index.global.js (1 hunks)
• composition-go/polyfill.go (1 hunks)
• composition-go/shim/src/polyfill.js (1 hunks)
• composition-go/vm_goja.go (1 hunks)
• composition-go/vm_v8.go (2 hunks)

🧰 Additional context used

🪛 checkmake (0.2.2)

composition-go/Makefile

[warning] 5-5: Missing required phony target "all"

(minphony)

---

[warning] 5-5: Missing required phony target "clean"

(minphony)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: build_push_image
• GitHub Check: build_test
• GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
• GitHub Check: integration_test (./events)
• GitHub Check: image_scan
• GitHub Check: build_push_image (nonroot)
• GitHub Check: image_scan (nonroot)
• GitHub Check: integration_test (./telemetry)
• GitHub Check: build_test
• GitHub Check: Analyze (go)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (5)

composition-go/shim/src/polyfill.js (1)

14-16: LGTM! Clean implementation of URL.canParse polyfill.

The static method implementation correctly delegates to the runtime-provided urlCanParse function, maintaining consistency with the existing urlParse pattern.

composition-go/Makefile (1)

1-5: LGTM! Focused test configuration for both VM implementations.

The Makefile correctly tests both the default (Goja) and V8 implementations with appropriate verbose output. The static analysis warnings about missing "all" and "clean" targets are acceptable for this focused testing Makefile.

composition-go/vm_goja.go (1)

79-81: LGTM! Consistent runtime binding implementation.

The urlCanParse binding follows the established pattern for runtime function exposure and includes proper error handling.

composition-go/vm_v8.go (2)

242-253: LGTM! Correct V8 wrapper function implementation.

The urlCanParseV8 function properly extracts the URL argument, calls the Go urlCanParse function, and handles the boolean result conversion to V8 value with appropriate error handling.

---

270-273: LGTM! Proper V8 binding registration.

The urlCanParse function template is correctly registered as a read-only global function, following the established pattern for other runtime bindings.

[Aenimus]

LGTM!