Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto ignore schema errors for check command if github is integrated #184

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

thisisnithin
Copy link
Member

Motivation and Context

We do not want to fail the command in the case we have a github integration. Only the commit check should be marked unsuccessful instead.

@github-actions github-actions bot added the cli label Oct 13, 2023
@thisisnithin thisisnithin enabled auto-merge (squash) October 13, 2023 09:25
@thisisnithin thisisnithin disabled auto-merge October 16, 2023 10:53
@thisisnithin thisisnithin changed the title feat: ignore errors option for checks feat: auto ignore schema errors for check command if github is integrated Oct 16, 2023
@thisisnithin thisisnithin enabled auto-merge (squash) October 16, 2023 10:56
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnithin thisisnithin merged commit 05d1b4a into main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants