-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better epoll detection, allow to disable epoll #1381
feat: better epoll detection, allow to disable epoll #1381
Conversation
The tag release you reference doesn't have a package that is used somewhere in Cosmo according to the failed CI. |
This is fine because we haven't released the engine yet. |
Ah, you were using replace with your local branch? But then should this PR be a draft? |
Yes, could be, but it was ready to review. I was only waiting for the engine release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I believe CI will be fine upon engine tag update.
…ion-and-allow-to-disable-it-by
Cosmo PR: wundergraph/cosmo#1381 Tested manually on docker with limited host capabilities.
Motivation and Context
This PR enables users to disable EPOLL support. In addition, we improved EPOLL support detection by a real integration test. In practice, users won't need to disable it manually anymore. I tested it manually on docker with limited host capabilities.
I also get rid of the terms EPOLL and KQUEUE in the configuration because they depends on the operating system. We abstract them away.
Breaking changes
The following internal engine flags (including their ENV equivalent) have been renamed for clarity.
Requires: wundergraph/graphql-go-tools#984
Checklist