Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): consider public and private directives for cache control #1314

Merged

Conversation

df-wg
Copy link
Contributor

@df-wg df-wg commented Oct 27, 2024

Motivation and Context

Previous efforts to add complex cache control policies didn't address the public/private directives which are documented here. This PR adds them, and refactors the cache control code to make it clearer and more maintainable.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

@df-wg df-wg enabled auto-merge (squash) October 28, 2024 17:29
@df-wg df-wg merged commit f0da638 into main Oct 28, 2024
9 checks passed
@df-wg df-wg deleted the dave/eng-5809-unexpected-cache-control-headers-in-cosmo-v01160 branch October 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants