-
Notifications
You must be signed in to change notification settings - Fork 0
Add wuji-teleop-ros2 project to README #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
adding the teleop-ros2 to github page
Walkthrough在 Teleoperation 分类中新增仓库 Changes
Sequence Diagram(s)(无序列图 — 仅文档与配置项新增,未引入新的多组件控制流。) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@profile/README.md`:
- Around line 76-80: In the table row containing the link text
"wuji-teleop-ros2", remove the trailing ".git" from the href URL so it matches
other GitHub links, and change the description text "Ros2 Teleop system: Full
teleoperation system with Tianji arm based on Ros2." to use consistent casing
"ROS2" (e.g., "ROS2 Teleop system: Full teleoperation system with Tianji arm
based on ROS2.").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
profile/README.md (1)
69-83: 修复表格结构:将“Teleoperation”表头合并为 rowspan=2,避免 脱离
当前 Lines 76-78 的<td>不在任何<tr>内,会导致表格渲染异常。建议把上一行表头的rowspan改为 2,并移除多余的表头单元格。🔧 建议修改
- <tr> - <td colspan="1" rowspan="1" align="center" class="ai-notebooks-table-points ai-orange-link"> + <tr> + <td colspan="1" rowspan="2" align="center" class="ai-notebooks-table-points ai-orange-link"> Teleoperation </td> <td><a href="/wuji-technology/wuji-retargeting" target="_blank"> wuji-retargeting </a> <br> Hand pose retargeting system: high-precision retargeting system based on DexRetargeting algorithm, supporting Vision Pro hand tracking for real-time teleoperation. </td> <td><img alt="Stars" src="https://img.shields.io/github/stars/wuji-technology/wuji-retargeting?style=flat-square"/></td> <td><img alt="Forks" src="https://img.shields.io/github/forks/wuji-technology/wuji-retargeting?style=flat-square"/></td> </tr> - <td colspan="1" rowspan="1" align="center" class="ai-notebooks-table-points ai-orange-link"> - Teleoperation - </td> <tr> <td><a href="/wuji-technology/wuji-teleop-ros2" target="_blank"> wuji-teleop-ros2 </a> <br> Ros2 Teleop system: Full teleoperation system with Tianji arm based on ROS2. </td> <td><img alt="Stars" src="https://img.shields.io/github/stars/wuji-technology/wuji-teleop-ros2?style=flat-square"/></td> <td><img alt="Forks" src="https://img.shields.io/github/forks/wuji-technology/wuji-teleop-ros2?style=flat-square"/></td> </tr>
♻️ Duplicate comments (1)
profile/README.md (1)
80-80: 统一大小写:将 “Ros2” 改为 “ROS2”
与其它条目一致性问题(已在历史评论中提出)。
- ROS2 should be uppercase (proper noun) - Description follows format: "Noun phrase: lowercase description." Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
zhangwt20011015
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢 CodeRabbit 的审查!所有问题已在最新提交中解决:
- ✅ ROS2 大小写问题 - 已修复,"Ros2" 改为 "ROS2"
- ✅ 表格结构 (rowspan) - 已正确设置
rowspan="2",<td>在正确的<tr>内 - ✅ URL .git 后缀 - 当前 URL 无
.git后缀
当前 description 已按规范更新为:
ROS2 teleoperation package: full teleoperation system integrating Wuji Hand with Tianji arm for real-time control.
|
根据飞书 GitHub 对外文案规范,建议将 wuji-teleop-ros2 的描述更新为与 repo description 一致: 当前 PR 中的描述:
建议修改为:
原因:
已将 |
|
更新:建议描述修改为:
不强调具体输入设备品牌,保持通用性。已同步更新 repo description。 |
|
确认: 正确流程:
这样可以确保 description 与各仓库设置保持同步。我已将
|
Let the update-profile workflow handle README updates automatically. Only keep repos-config.yml changes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
adding the teleop-ros2 to github page
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.