forked from pingcap/tidb
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
disttask: cleanup framework meta when nodes shutdown (pingcap#47536)
ref pingcap#46258
- Loading branch information
Showing
15 changed files
with
613 additions
and
93 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
pkg/disttask/framework/dispatcher/dispatcher_manager_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| // Copyright 2023 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package dispatcher_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/ngaut/pools" | ||
| "github.com/pingcap/tidb/pkg/disttask/framework/dispatcher" | ||
| "github.com/pingcap/tidb/pkg/disttask/framework/mock" | ||
| "github.com/pingcap/tidb/pkg/disttask/framework/proto" | ||
| "github.com/pingcap/tidb/pkg/testkit" | ||
| "github.com/stretchr/testify/require" | ||
| "go.uber.org/mock/gomock" | ||
| ) | ||
|
|
||
| func TestCleanUpRoutine(t *testing.T) { | ||
| store := testkit.CreateMockStore(t) | ||
| gtk := testkit.NewTestKit(t, store) | ||
| pool := pools.NewResourcePool(func() (pools.Resource, error) { | ||
| return gtk.Session(), nil | ||
| }, 1, 1, time.Second) | ||
| defer pool.Close() | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
|
|
||
| dsp, mgr := MockDispatcherManager(t, pool) | ||
| mockCleanupRountine := mock.NewMockCleanUpRoutine(ctrl) | ||
| mockCleanupRountine.EXPECT().CleanUp(gomock.Any(), gomock.Any()).Return(nil).AnyTimes() | ||
| dispatcher.RegisterDispatcherFactory(proto.TaskTypeExample, | ||
| func(ctx context.Context, taskMgr dispatcher.TaskManager, serverID string, task *proto.Task) dispatcher.Dispatcher { | ||
| mockDispatcher := dsp.MockDispatcher(task) | ||
| mockDispatcher.Extension = &numberExampleDispatcherExt{} | ||
| return mockDispatcher | ||
| }) | ||
| dispatcher.RegisterDispatcherCleanUpFactory(proto.TaskTypeExample, | ||
| func() dispatcher.CleanUpRoutine { | ||
| return mockCleanupRountine | ||
| }) | ||
| dsp.Start() | ||
| defer dsp.Stop() | ||
| require.NoError(t, mgr.StartManager(":4000", "background")) | ||
|
|
||
| taskID, err := mgr.AddNewGlobalTask("test", proto.TaskTypeExample, 1, nil) | ||
| require.NoError(t, err) | ||
|
|
||
| checkTaskRunningCnt := func() []*proto.Task { | ||
| var tasks []*proto.Task | ||
| require.Eventually(t, func() bool { | ||
| var err error | ||
| tasks, err = mgr.GetGlobalTasksInStates(proto.TaskStateRunning) | ||
| require.NoError(t, err) | ||
| return len(tasks) == 1 | ||
| }, time.Second, 50*time.Millisecond) | ||
| return tasks | ||
| } | ||
|
|
||
| checkSubtaskCnt := func(tasks []*proto.Task, taskID int64) { | ||
| require.Eventually(t, func() bool { | ||
| cnt, err := mgr.GetSubtaskInStatesCnt(taskID, proto.TaskStatePending) | ||
| require.NoError(t, err) | ||
| return int64(subtaskCnt) == cnt | ||
| }, time.Second, 50*time.Millisecond) | ||
| } | ||
|
|
||
| tasks := checkTaskRunningCnt() | ||
| checkSubtaskCnt(tasks, taskID) | ||
| for i := 1; i <= subtaskCnt; i++ { | ||
| err = mgr.UpdateSubtaskStateAndError(int64(i), proto.TaskStateSucceed, nil) | ||
| require.NoError(t, err) | ||
| } | ||
| dsp.DoCleanUpRoutine() | ||
| require.Eventually(t, func() bool { | ||
| tasks, err := mgr.GetGlobalTasksFromHistoryInStates(proto.TaskStateSucceed) | ||
| require.NoError(t, err) | ||
| return len(tasks) != 0 | ||
| }, time.Second*10, time.Millisecond*300) | ||
| } | ||
|
|
||
| func TestCleanUpMeta(t *testing.T) { | ||
| store := testkit.CreateMockStore(t) | ||
| gtk := testkit.NewTestKit(t, store) | ||
| pool := pools.NewResourcePool(func() (pools.Resource, error) { | ||
| return gtk.Session(), nil | ||
| }, 1, 1, time.Second) | ||
| defer pool.Close() | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
| mockTaskMgr := mock.NewMockTaskManager(ctrl) | ||
| mockCleanupRountine := mock.NewMockCleanUpRoutine(ctrl) | ||
| dspMgr := MockDispatcherManagerWithMockTaskMgr(t, pool, mockTaskMgr) | ||
| dispatcher.RegisterDispatcherFactory(proto.TaskTypeExample, | ||
| func(ctx context.Context, taskMgr dispatcher.TaskManager, serverID string, task *proto.Task) dispatcher.Dispatcher { | ||
| mockDispatcher := dspMgr.MockDispatcher(task) | ||
| mockDispatcher.Extension = &numberExampleDispatcherExt{} | ||
| return mockDispatcher | ||
| }) | ||
| dispatcher.RegisterDispatcherCleanUpFactory(proto.TaskTypeExample, | ||
| func() dispatcher.CleanUpRoutine { | ||
| return mockCleanupRountine | ||
| }) | ||
|
|
||
| mockTaskMgr.EXPECT().GetAllNodes().Return([]string{":4000", ":4001"}, nil) | ||
| mockTaskMgr.EXPECT().CleanUpMeta(gomock.Any()).Return(nil) | ||
| mockCleanupRountine.EXPECT().CleanUp(gomock.Any(), gomock.Any()).Return(nil).AnyTimes() | ||
| require.Equal(t, 1, dspMgr.CleanUpMeta()) | ||
|
|
||
| mockTaskMgr.EXPECT().GetAllNodes().Return([]string{":4000"}, nil) | ||
| mockCleanupRountine.EXPECT().CleanUp(gomock.Any(), gomock.Any()).Return(nil).AnyTimes() | ||
| require.Equal(t, 0, dspMgr.CleanUpMeta()) | ||
|
|
||
| mockTaskMgr.EXPECT().GetAllNodes().Return([]string{":4000", ":4001", ":4003"}, nil) | ||
| mockTaskMgr.EXPECT().CleanUpMeta(gomock.Any()).Return(nil) | ||
| mockCleanupRountine.EXPECT().CleanUp(gomock.Any(), gomock.Any()).Return(nil).AnyTimes() | ||
| require.Equal(t, 2, dspMgr.CleanUpMeta()) | ||
| } |
Oops, something went wrong.