fix(skia): transparent fill not work

wuba · Apr 26, 2024 · 68c325f · 68c325f
1 parent 7d2a168
commit 68c325f
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/SVGCore.ts b/src/SVGCore.ts
@@ -50,9 +50,15 @@ export function vNodeToString(
   const S = opts.newline ? '\n' : '';
   function convertElToString(el: SVGVNode): string {
     const { children, tag, attrs } = el;
-    // fix: https://github.com/Shopify/react-native-skia/issues/888
-    if (attrs['stroke-width'] === 0) {
-      attrs['stroke-opacity'] = 0;
+    if (tag === 'path') {
+      // fix: https://github.com/Shopify/react-native-skia/issues/888
+      if (attrs['stroke-width'] === 0) {
+        attrs['stroke-opacity'] = 0;
+      }
+      // fix: https://github.com/wuba/react-native-echarts/issues/161
+      if (attrs['fill'] === 'transparent') {
+        attrs['fill-opacity'] = 0;
+      }
     }
     if (tag === 'text') {
       if (typeof attrs.style === 'string') {