Merge pull request taosdata#12824 from ideal/develop

fix: potential overflow of pThread->label
wu-champion · Oct 22, 2022 · 2a660b0 · 2a660b0
2 parents 3cc132b + bf9b9ac
commit 2a660b0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/plugins/http/inc/httpInt.h b/src/plugins/http/inc/httpInt.h
@@ -175,7 +175,7 @@ typedef struct HttpThread {
   EpollFd         pollFd;
   int32_t         numOfContexts;
   int32_t         threadId;
-  char            label[HTTP_LABEL_SIZE << 1];
+  char            label[HTTP_LABEL_SIZE << 2];
   bool (*processData)(HttpContext *pContext);
 } HttpThread;
 

diff --git a/src/plugins/http/src/httpServer.c b/src/plugins/http/src/httpServer.c
@@ -313,7 +313,7 @@ bool httpInitConnect() {
 
   HttpThread *pThread = pServer->pThreads;
   for (int32_t i = 0; i < pServer->numOfThreads; ++i) {
-    sprintf(pThread->label, "%s%d", pServer->label, i);
+    snprintf(pThread->label, sizeof(pThread->label), "%s%d", pServer->label, i);
     pThread->processData = pServer->processData;
     pThread->threadId = i;