Skip to content

Fix/review 414 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mprzypasniak99 wants to merge 46 commits into from
Closed

Fix/review 414 #418

mprzypasniak99 wants to merge 46 commits into from

Conversation

@mprzypasniak99
Copy link
Collaborator

@mprzypasniak99 mprzypasniak99 commented Nov 13, 2021

Description

Made changes requested in PR #414

Motivation and Context

#414

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Automated functional tests have been added or modified to cover my changes (if applicable)
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Cogboard Contributor License Agreement.

mprzypasniak99 and others added 30 commits September 25, 2021 18:18
@mprzypasniak99
Created LogViewerWidget
291be47
@mprzypasniak99
Added LogViewer to WidgetIndex
af06dd9
@mprzypasniak99
Added WireMock for LogViewer
cd3a269
@przemekxa
Remove ALL log level, use INFO as default
ba65c41
@mprzypasniak99
Added placeholder method for processing logs before sending to front-end
954f9af
@mprzypasniak99
Merge branch 'enhancement/log-viewer-widget' into feature/381
e28ceab
@mprzypasniak99
Changed to using strategies [#381]
783fb34
@mprzypasniak99
Merge remote-tracking branch 'origin/feature/381' into feature/381
e6f39b0 
# Conflicts:
#	cogboard-app/src/main/kotlin/com/cognifide/cogboard/CogboardConstants.kt
@mprzypasniak99
Strategy adjustments [#381]
75fff1f
@mprzypasniak99
Added tests and Strategies implementations [#381]
de0aea0
@mprzypasniak99
Deleted SSHWidget - replaced by strategies [#381]
1dbb996
@Borrubasz
Changes after code review - problem with tests to solve
23a2b6b
@clmrv
Add ssh to endpoints dialog fields #412
3239153
@mprzypasniak99
Tests fixed
26a173e
@przemekxa
Add SSH Key field to Credentials
737c288
@przemekxa
Modify credential test
7d2f0b2
@przemekxa
Change SSH Key regex
5729dae
@przemekxa
Add OpenSSH docker image
b5a967e
@mprzypasniak99
Deleted SSH tests to move them to different branch
8acac96
@mprzypasniak99
Merge remote-tracking branch 'origin/feature/381' into feature/381
989ee33
@mprzypasniak99
Code review changes [#381]
9b2ffcf
@clmrv
Merge branch 'feature/412' into feature/376-381-412
604f8ca
@clmrv
Merge remote-tracking branch 'origin/feature/381' into feature/376-38…
743c4be 
…1-412
@clmrv
Add ssh to credentials tests, Turn off LogViewer backend
82945f2
@przemekxa
Change text fo file
7178432
@przemekxa
Merge branch 'feature/412' into feature/376-381-412
c7f3fd5
@przemekxa
Add SSH Key passphrase
622953c
@przemekxa
Merge branch 'feature/412' into feature/376-381-412
48008a9
@clmrv
Move template logs to backend
c467182
@mprzypasniak99
Adjustments for communication with front-end
7a341e7
@mprzypasniak99 mprzypasniak99 deleted the fix/review-414 branch November 14, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheTerabit TheTerabit TheTerabit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mprzypasniak99 @TheTerabit @przemekxa @Borrubasz @clmrv