This repository was archived by the owner on Nov 23, 2021. It is now read-only.
Webdriver initialisation rework #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced WebDriverCreatorsModule
…Driver has its own factory
…ng them in the DesiredCapabilitiesProvider
Shaihuludus
approved these changes
Jan 9, 2019
|
@mkrzyzanowski pl review and merge the code |
- integration tests - appium module introduced
- Creators for each driver created - bb-appium module added containing creators for Appium-based drivers - tests reorganized to provide a better control - BobcatExtension annotation introduced for easier test creation
This was referenced Aug 13, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework of how Bobcat initialises WebDriver instances: now each driver has its separated creator, that can be easily swapped or new drivers can be easily added.
Motivation and Context
This decouples the creation of browser-specific WebDriver instances, thus making browser-related options easier to manipulate (e.g. to help with #188).
Types of changes
Checklist: