fix tab completion selecting wrong directory#731
Open
kevinburkesegment wants to merge 1 commit intowting:masterfrom
Open
fix tab completion selecting wrong directory#731kevinburkesegment wants to merge 1 commit intowting:masterfrom
kevinburkesegment wants to merge 1 commit intowting:masterfrom
Conversation
handle_tab_completion used check_entries=False when generating the tab menu and resolving tab indices, but main() used check_entries=True (the default) when jumping. Non-existent paths in the database were included in the menu numbering but excluded during the jump, causing indices to shift and the wrong directory to be selected. Use check_entries=True (the default) consistently in handle_tab_completion to match the behavior in main(). Fixes wting#729 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_tab_completion used check_entries=False when generating the tab menu and resolving tab indices, but main() used check_entries=True (the default) when jumping. Non-existent paths in the database were included in the menu numbering but excluded during the jump, causing indices to shift and the wrong directory to be selected.
Use check_entries=True (the default) consistently in handle_tab_completion to match the behavior in main().
Fixes #729