Parse literal IPv6 addresses in hostnames #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2018 12:38
See RFC 2732. Resolves wtetzner#19.
Contributor
Author
|
Thanks for merging, @wtetzner! Could you please do a version bump and Clojars release? I have a rogue release up on https://clojars.org/ljosa/exploding-fish but would prefer not to. |
Owner
|
@ljosa, I've built a new release and pushed it to Clojars: https://clojars.org/org.bovinegenius/exploding-fish/versions/0.3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to support IPv6 addresses in square brackets as hostnames in URLs in accordance with RFC 2732. I'm doing this not for sport but because I encountered such URLs in the wild, and they caused a NumberFormatException. See #19, which this resolves.