Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added required_ruby_version >= 2.7 into gemspec #209

Merged

Conversation

skunkworker
Copy link
Contributor

With the recent constraint of dropping support for Ruby 2.6 (which also includes JRuby 9.3), the minimum ruby version should be constrained in the gemspec so that it cannot be resolved for older versions.

In addition I would recommend re-releasing 4.0.0, 4.0.1, 4.0.2 gems so that 3.1.0 would be pulled in correctly.

@skunkworker skunkworker changed the title added required_ruby_version into gemspec added required_ruby_version >= 2.7 into gemspec Aug 31, 2023
@wspurgin
Copy link
Owner

wspurgin commented Sep 1, 2023

Thanks @skunkworker I definitely should've added it in the gemspec in the first place, and I'll cop to that.

However, I can't republish versions to rubygems. It's disallowed (for natural security reasons). The most I could do is yank previous versions which I don't particularly want to do either. Since it's in the change log and release notes that we dropped support for <2.7 (and attempting to use an older Ruby will produce breakages), I'll let the previous versions stand.

Thanks for the PR!

@wspurgin wspurgin merged commit 89b5094 into wspurgin:main Sep 1, 2023
28 checks passed
@skunkworker skunkworker deleted the constrain_ruby_gemspec_version_27 branch September 5, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants