Add initial helm chart files #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorna2152
requested review from
gimantha,
AnuGayan,
kavindasr,
RakhithaRR,
tharindu-nw and
anuruddhal
kavindasr
reviewed
Mar 28, 2025
poorna2152
force-pushed
the
add_initial
branch
2 times, most recently
from
b2b6408 to
7e2596a
Compare
kavindasr
reviewed
Mar 30, 2025
RakhithaRR
reviewed
Mar 31, 2025
confs/deployment.yaml
Outdated
| # Trust store path | ||
| trustStorePath: '${sys:carbon.home}/resources/security/client-truststore.jks' | ||
| # Trust store password | ||
| trustStorePassword: 'wso2carbon' |
There was a problem hiding this comment.
Shall we check whether any other properties need to be configurable?
| - host: {{ .Values.wso2.deployment.hostname | quote }} | ||
| http: | ||
| paths: | ||
| - path: /siddhi-apps |
There was a problem hiding this comment.
Is this the only path that is needed? Could there be any other paths?
There was a problem hiding this comment.
For the moment only exposed the Siddhi Apps API. There can be other paths which are depends on the user deployments that the user have to specify.
RakhithaRR
approved these changes
Mar 31, 2025
SanojPunchihewa
approved these changes
Mar 31, 2025
kavindasr
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$subject
This involves adding a stateful set which deploys given number of replicas to a kubernetes cluster. The
wso2carbon: idis unique between the pods and it is set to be the podname