Skip to content

Comments

Upgrade JDK version to 21 in UI tests#1254

Merged
PasanT9 merged 1 commit intowso2:mainfrom
PasanT9:470-1
Feb 23, 2026
Merged

Upgrade JDK version to 21 in UI tests#1254
PasanT9 merged 1 commit intowso2:mainfrom
PasanT9:470-1

Conversation

@PasanT9
Copy link
Contributor

@PasanT9 PasanT9 commented Feb 23, 2026

$subject

Summary by CodeRabbit

  • Chores
    • Upgraded Java version from 11 to 21 in continuous integration and testing environments.

@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

Walkthrough

Updated GitHub Actions CI/CD workflows to use Java 21 instead of Java 11 for the setup-java action, maintaining Temurin as the distribution across two workflow files.

Changes

Cohort / File(s) Summary
CI/CD Java Version Upgrade
.github/workflows/main.yml, .github/workflows/ui-test.yml
Updated JDK version from 11 to 21 in setup-java action configuration and renamed step name in ui-test workflow accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hops with glee,
Java twenty-one's the key,
Workflows now run spry,
Faster code, oh my!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title references upgrading JDK to 21 in UI tests, but changes affect both main.yml and ui-test.yml workflows, making it partially accurate. Consider revising the title to reflect that JDK 21 is being upgraded in both CI workflows (main.yml and ui-test.yml), not just UI tests.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/main.yml (1)

24-28: Step name not updated to match the new JDK version.

The step is still named Set up JDK while the parallel step in ui-test.yml was correctly renamed to Set up JDK 21. Update the name here for consistency.

✏️ Proposed fix
-      - name: Set up JDK
+      - name: Set up JDK 21
         uses: actions/setup-java@v4
         with:
           java-version: 21
           distribution: 'temurin'
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/main.yml around lines 24 - 28, The workflow step currently
named "Set up JDK" should be renamed to "Set up JDK 21" for consistency with the
other workflow; locate the step that uses actions/setup-java@v4 with
java-version: 21 (the step whose name reads "Set up JDK") and update its name
string to "Set up JDK 21" so both workflows match.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/main.yml:
- Around line 24-28: The workflow step currently named "Set up JDK" should be
renamed to "Set up JDK 21" for consistency with the other workflow; locate the
step that uses actions/setup-java@v4 with java-version: 21 (the step whose name
reads "Set up JDK") and update its name string to "Set up JDK 21" so both
workflows match.

@PasanT9 PasanT9 merged commit da68659 into wso2:main Feb 23, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants