Repository navigation
release: the six changes that merged without a changelog entry - #476
Merged
Merged
Conversation
RELEASING.md asks for the entry in the same PR as the code, and six user-facing changes went in without one. Five of them are the chain the acceptance suite turned up once it actually ran, each hidden behind the one before it, and #429 is listed in 0.6.0's Known issues as still broken: #429 restart --supervisor lost the pipe it was serving #468 a dead dockerd read as "cannot tell", so the supervisor stopped repairing it -- plus the restore diagnostics that found it #471 uninstall disowned a context its own supervisor had set #472 uninstall left the supervisor running, holding skrog.exe open #444 autostart failed on a profile with no Run key The emulation entry also gains the fact a reader needs and it did not carry: the emulator is IN the rootfs, so the feature wants engine 29.8.1-3 or newer, and an older image says `missing interpreter` and runs without emulation rather than registering a handler pointing at nothing. Separately, site/home.md still told visitors code signing "is applied for through the SignPath Foundation, with signing by SignPath.io". The application was declined (#358). README.md, docs/install.md and docs/code-signing.md all say so; the site landing page was the one file left claiming otherwise, and it is the page the docs site opens on. The heading stays [Unreleased]. Dating it is the last commit before the tag, as #427 did for 0.6.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for 0.7.0. No code changes.
Six changes merged without a changelog entry
RELEASING.md asks for the entry in the same PR as the last code change. These six did not get one:
restart --supervisorlost the pipe it was servingdockerdread as "cannot tell", so the supervisor stopped repairing it — plus the restore diagnostics that found itskrog.exeopenRunkeyFive of them are one chain: the acceptance suite found each only after the one before it was fixed. #429 is currently listed in 0.6.0's Known issues as still broken, so shipping 0.7.0 without recording the fix would leave the last published word on it wrong.
The 0.6.0 section is left exactly as it is. A released section is a record of what was true then.
The emulation entry gains the fact it was missing
The emulator is in the rootfs, so
emulation.platformsneeds engine 29.8.1-3 or newer — the revision that first carries it. The entry described the feature without saying that, which is the difference between "I set the key and it works" and "I set the key and nothing happened".On an older image the start path prints
missing interpreterand carries on without emulation rather than registering a handler pointing at nothing, so the failure is diagnosable — but only if you know to expect it.This is also why the rootfs has to be re-cut before the app tag:
rootfs-v29.8.1-2was published before the emulator landed inguest/.site/home.md was telling visitors something untrue
The Foundation's free programme declined (#358).
README.md,docs/install.mdanddocs/code-signing.mdall say so correctly — the site landing page was the one file still claiming an active application, and it is the page https://wslkit.github.io/skrog/ opens on. Now mirrors the README's wording, and drops the SignPath.io attribution, which was never ours to display.Checks
scripts/build-docs.ps1 -Strictbuilds cleanscripts/check-links.ps1— links: all resolve (44 files)Not in this PR
ROOTFS_REVISION=3— separate, because it gates the rootfs tag[Unreleased]to[0.7.0] — <date>, which is the last commit before the tag, as release: date the 0.6.0 changelog entry #427 did for 0.6.0