Repository navigation
robustness: atomic manifest, distro-name validation, log-rotation recovery, console attrs - #104
Merged
Merged
Conversation
…overy, console attrs P3 batch from the v0.2.0 review (#93): - writeManifest now writes tmp+rename like every other state file; a crash mid-write no longer corrupts manifest.json into a "no install found" state. - distro names are validated ([A-Za-z0-9._-]+, no . or ..) at the Install boundary, closing the class where a name reaches the /mnt/wsl unshare rm -rf path or a wsl-integrate profile-script line. - RotatingWriter recovers a nil handle: a rotation that closed the file and failed to reopen left w.f pointing at a closed handle, so every later line vanished silently; Write now reopens on demand, rotate closes best-effort (a Close error no longer aborts rotation), and open() clears a stale handle on failure. - consoleHandler.WithAttrs/WithGroup are implemented instead of dropped, so log.With(...) context survives (attrs render inline, groups become a key prefix). Closes #93 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
zcsizmadia
force-pushed
the
fix/state-robustness
branch
from
September 6, 2026 02:44
3e2e166 to
77ac172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P3 batch from the v0.2.0 review (#93):
mid-write no longer corrupts manifest.json into a "no install found" state.
boundary, closing the class where a name reaches the /mnt/wsl unshare
rm -rf path or a wsl-integrate profile-script line.
failed to reopen left w.f pointing at a closed handle, so every later line
vanished silently; Write now reopens on demand, rotate closes best-effort
(a Close error no longer aborts rotation), and open() clears a stale handle
on failure.
log.With(...) context survives (attrs render inline, groups become a key
prefix).
Closes #93
Co-Authored-By: Claude Opus 5 noreply@anthropic.com