Skip to content

Commit

Permalink
media: Revert "media: em28xx: add missing em28xx_close_extension"
Browse files Browse the repository at this point in the history
This reverts commit 2c98b8a.

Reverted patch causes problems with Hauppauge WinTV dualHD as Maximilian
reported [1]. Since quick solution didn't come up let's just revert it
to make this device work with upstream kernels.

Link: https://lore.kernel.org/all/6a72a37b-e972-187d-0322-16336e12bdc5@elbmurf.de/ [1]

Reported-by: Maximilian Böhm <maximilian.boehm@elbmurf.de>
Tested-by: Maximilian Böhm <maximilian.boehm@elbmurf.de>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
  • Loading branch information
pskrgag authored and mchehab committed Mar 7, 2022
1 parent 22beb83 commit fde18c3
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/media/usb/em28xx/em28xx-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -4150,11 +4150,8 @@ static void em28xx_usb_disconnect(struct usb_interface *intf)

em28xx_close_extension(dev);

if (dev->dev_next) {
em28xx_close_extension(dev->dev_next);
if (dev->dev_next)
em28xx_release_resources(dev->dev_next);
}

em28xx_release_resources(dev);

if (dev->dev_next) {
Expand Down

0 comments on commit fde18c3

Please sign in to comment.