Skip to content

Commit

Permalink
USB: enable USB-PERSIST by default
Browse files Browse the repository at this point in the history
This patch (as1052) enables USB-PERSIST for all devices by default.
The user won't have to remember to enable it explicitly for devices
containing mounted filesystems.

Eventually userspace tools like hal may be able to set the persist
attribute automatically when a filesystem is mounted on a USB device.
When that time comes this patch can be reverted, if people think it
matters.

This approach has the advantage of giving the user the ability to turn
off USB-PERSIST for devices with mounted filesystems, rather than
making the kernel always assume it should be on.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
AlanStern authored and gregkh committed Apr 25, 2008
1 parent eb764c4 commit 9214d1d
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/usb/core/quirks.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,14 @@ void usb_detect_quirks(struct usb_device *udev)
udev->autosuspend_disabled = 1;
#endif

#ifdef CONFIG_PM
/* For the present, all devices default to USB-PERSIST enabled */
#if 0 /* was: #ifdef CONFIG_PM */
/* Hubs are automatically enabled for USB-PERSIST */
if (udev->descriptor.bDeviceClass == USB_CLASS_HUB)
udev->persist_enabled = 1;

#else
/* In the absense of PM, we can safely enable USB-PERSIST
/* In the absence of PM, we can safely enable USB-PERSIST
* for all devices. It will affect things like hub resets
* and EMF-related port disables.
*/
Expand Down

0 comments on commit 9214d1d

Please sign in to comment.