Skip to content

Commit

Permalink
sparc: _sparc_find_resource() should check for exact matches
Browse files Browse the repository at this point in the history
The address that's passed to _sparc_find_resource() should always be the
start address of a resource:
  - iounmap() passes a page-aligned virtual address, while the original
    address was created by adding the in-page offset to the resource's
    start address,
  - sbus_free_coherent() and pci32_free_coherent() should be passed an
    address obtained from sbus_alloc_coherent() resp. pci32_alloc_coherent(),
    which is always a resource's start address.

Hence replace the range check by a check for an exact match.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
geertu committed Jul 30, 2011
1 parent 1dad6c7 commit 88efd0b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/sparc/kernel/ioport.c
Original file line number Diff line number Diff line change
Expand Up @@ -723,12 +723,12 @@ static const struct file_operations sparc_io_proc_fops = {
* This probably warrants some sort of hashing.
*/
static struct resource *_sparc_find_resource(struct resource *root,
unsigned long hit)
unsigned long start)
{
struct resource *tmp;

for (tmp = root->child; tmp != 0; tmp = tmp->sibling) {
if (tmp->start <= hit && tmp->end >= hit)
if (tmp->start == start)
return tmp;
}
return NULL;
Expand Down

0 comments on commit 88efd0b

Please sign in to comment.