🐛: santoku-appのgoogle-services.dummy.jsonをそのまま使えるように修正 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in-a-paddy
changed the title
package_name値をdummyからjp.fintan.mobile.santokuappに修正
in-a-paddy
approved these changes
Jul 13, 2021
tani-takanori
approved these changes
Jul 14, 2021
in-a-paddy
deleted the
fix/santoku-app-google-services-json-dummy-package-name
branch
2 tasks
creature-water-valley
added a commit
that referenced
this pull request
May 8, 2023
## ✅ What's done [`rn-spoiler`のExpo SDK 48アップグレード対応](https://github.com/ws-4020/rn-spoiler/pull/133)で以下を検知 ToDo一覧画面のFAB（Icon）は、`react-native-elements`の`Icon`を使用していますが、`raised`を指定した場合に以下のWarningが出力されます。 > WARN (ADVICE) View #355 of type RCTView has a shadow set but cannot calculate shadow efficiently. Consider setting a background color to fix this, or apply the shadow to a more specific component. `shadow`関連のPropsを扱う場合は`backgroundColor`も設定した方が良いという警告ですが、`raised`を`true`に設定した場合に、`react-native-elements`では`backgroundColor`を設定していないようです。 - https://github.com/react-native-elements/react-native-elements/blob/v3.4.3/src/icons/Icon.tsx#L177 ToDoアプリでは、`Icon`の`raised`の使用を学習の目的としていないので、ToDo一覧画面のFAB（Icon）から`raised`を削除しました。 - [x] `raised`の削除 - 以下で対象を確認（`shadow`系のPropsを使用していないかも併せて確認） - `git grep -E "raised|shadow[Color|Offset|Opacity|Radius]" -- website/` - [x] ToDo一覧画面のキャプチャを貼り付ける箇所のキャプチャ更新
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What's done
dummyからjp.fintan.mobile.santokuappとjp.fintan.mobile.santokuapp.debugに修正Tests
android/app/google-sevices.dummy.jsonをandroid/app/google-sevices.jsonにコピーし、ファイル修正することなくアプリが起動することDevices
Other (messages to reviewers, concerns, etc.)
なし