Skip to content

Commit

Permalink
test: remove outdated V8 flag
Browse files Browse the repository at this point in the history
The `--concurrent-array-buffer-freeing` flag is going to be removed
upstream in V8 9.0.

PR-URL: nodejs/node-addon-api#895
Refs: v8/v8@0a480c3
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
wroy7860 committed Feb 12, 2021
1 parent 8e617b3 commit 3a41c0e
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ const majorNodeVersion = process.versions.node.split('.')[0];

if (typeof global.gc !== 'function') {
// Construct the correct (version-dependent) command-line args.
let args = ['--expose-gc', '--no-concurrent-array-buffer-freeing'];
let args = ['--expose-gc'];
const majorV8Version = process.versions.v8.split('.')[0];
if (majorV8Version < 9) {
args.push('--no-concurrent-array-buffer-freeing');
}
if (majorNodeVersion >= 14) {
args.push('--no-concurrent-array-buffer-sweeping');
}
Expand Down

0 comments on commit 3a41c0e

Please sign in to comment.