Repository navigation
fix: remove active-win entirely — Windows/Linux tracking deferred - #26
Merged
Merged
Conversation
active-win's binding.gyp triggers node-gyp during pnpm install itself, before electron-rebuild runs. Fails on windows-latest CI regardless of optionalDependencies/rebuild flags (VS 2022 not recognized by node-gyp's VS finder). Removed dependency entirely. Non-Mac platforms now return null from getActiveApp() with a clear TODO comment. App remains fully functional — onboarding, profile, manual features — just without automatic window detection on Windows/Linux until a pure-JS alternative is implemented. Mac (primary platform) unaffected — NSWorkspace/osascript approach has zero native dependencies. pnpm typecheck: zero errors pnpm build: successful
fix: remove active-win entirely — Windows/Linux tracking deferred
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.