Merged
Conversation
Signed-off-by: Angelo Stavrow <angelo@droppedbits.com>
Signed-off-by: Angelo Stavrow <angelo@droppedbits.com>
Signed-off-by: Angelo Stavrow <angelo@droppedbits.com>
AngeloStavrow
changed the title
AngeloStavrow
commented
Jul 16, 2023
Comment on lines
+31
to
+33
| resources: [ | ||
| .process("Resources") | ||
| ] |
Collaborator
Author
There was a problem hiding this comment.
This lets us use the test JSON files under Tests/WriteFreelyTests/Resources.
AngeloStavrow
commented
Jul 16, 2023
| var nextDataTask = MockURLSessionDataTask() | ||
| var nextData: Data? | ||
| var nextError: Error? | ||
| var expectedStatusCode: Int = 200 |
Collaborator
Author
There was a problem hiding this comment.
This lets us set our expected status code explicitly in our tests — not everything expects a 200 OK!
AngeloStavrow
commented
Jul 16, 2023
| } | ||
|
|
||
| @discardableResult | ||
| func setData(resource: String, fileExt: String, for target: XCTestCase) throws -> URL? { |
Collaborator
Author
There was a problem hiding this comment.
We use this to set the response JSON from a file in our Resources path.
AngeloStavrow
commented
Jul 16, 2023
Comment on lines
+5
to
+12
| static var allTests = [ | ||
| ("testCreateCollection_WithValidCollectionData_CreatesNewWFCollection", testCreateCollection_WithValidCollectionData_CreatesNewWFCollection), | ||
| ("testCreateCollection_WithInvalidCollectionData_ReturnsBadRequestError", testCreateCollection_WithInvalidCollectionData_ReturnsBadRequestError), | ||
| ("testGetCollection_WithValidCollectionData_RetrievesCollectionMetadata", testGetCollection_WithValidCollectionData_RetrievesCollectionMetadata), | ||
| ("testGetCollection_WithInvalidCollectionData_ReturnsInvalidDataError", testGetCollection_WithInvalidCollectionData_ReturnsInvalidDataError), | ||
| ("testDeleteCollection_WithValidCollectionAlias_ReturnsTrue", testDeleteCollection_WithValidCollectionAlias_ReturnsTrue), | ||
| ("testDeleteCollection_WithInvalidCollectionAlias_ReturnsInvalidResponseError", testDeleteCollection_WithInvalidCollectionAlias_ReturnsInvalidResponseError) | ||
| ] |
Collaborator
Author
There was a problem hiding this comment.
We focus here on the createCollection, getCollection, and deleteCollection methods on WFClient as "collection"-related methods.
The REST API includes things like getting a post from a collection, for example, but in the client we make that a "post"-related method as an overload on getPost.
This was referenced Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #4, adding tests for collection-related endpoints.