Add a comment for CRAY ifort stanza and move Fujitsu stanza to the end. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) add a comment to suggest the inclusion of -fp-model precise for CRAY ifort compilation to improve the WRFPLUS check_AD accuracy. 2) move the Fujitsu stanza to the end of the list On branch configure_defaults Changes to be committed: modified: arch/configure_new.defaults
mkavulich
approved these changes
Sep 23, 2016
dmey
added a commit
to TEB-model/wrf-teb
that referenced
this pull request
Mar 31, 2020
Removes some clutter and simplifies the README file and docs on how to install CMake from source.
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 15, 2021
Reverting Makefile modification added via PR-5 since we decided this …
twjuliano
pushed a commit
to twjuliano/WRF
that referenced
this pull request
Jun 13, 2022
Updated README for SWiFT_20131108_PertMethodsGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: text only
KEYWORDS: configure_new.defaults
SOURCE: Thomas Schwitalla (University of Hohenheim) + internal
DESCRIPTION OF CHANGES:
(1) add a comment to suggest the inclusion of -fp-model precise for CRAY ifort compilation.
By adding "-fp-model precise" to the ifort compiler flags for CRAY XC40,
the WRFPLUS check_AD result is satisfactory.
ad_check: VAL_TL: 0.28529390417423E+12
ad_check: VAL_AD: 0.28529390417425E+12
The imprecise result is something like
ad_check: VAL_TL: 0.29626592914807E+12
ad_check: VAL_AD: 0.29626592915255E+12
The "-fp-model precise" flag slows down the speed by ~2%.
(2) move the Fujitsu stanza to the end of the list and add back x86_64 to the ARCH title.
LIST OF MODIFIED FILES:
M arch/configure_new.defaults
TESTS CONDUCTED:
WRFDA regtests passed.
Need to run WTF tests.