mass redistribution between GOCART dust/sea salt and MOZAIC bins #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOZAIC bins should be computed using interpolation over the logarithmic axis
|
@saneku
|
|
@kayeekayee @ravanah @stacywalters |
saneku
changed the title
1&2 are done |
|
@kayeekayee @ravanah @stacywalters |
|
Dave,
I've got a problem with this PR. I understand what has been changed but
I'm not one to say whether this is the way to go. It seems plausible to me
but if you want genuine scientific input I'd like Mary Barth to have a look.
Trouble is I don't know how to get the relevant code to her.
Stacy
…On Mon, Oct 29, 2018 at 1:40 PM Dave Gill ***@***.***> wrote:
@kayeekayee <https://github.com/kayeekayee> @ravanah
<https://github.com/ravanah> @stacywalters
<https://github.com/stacywalters>
WRF Chem team,
Would one of the WRF Chem team please provide a technical review. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#677 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIHAksy0_IiFc26rHEeRplqR0_Q5zt60ks5upz2fgaJpZM4X5H5q>
.
|
|
@stacywalters
She just needs to know to toggle to between these two pages.
Get to a clean place on a local machine, and get Alexander's code: Get into that directory Make a couple of the remotes local Get a difference of the impacted file |
|
@stacywalters |
|
Dave,
Our scientists went to sleep on this. I believe the mod is fine but as of
now we don't have
scientific confirmation. So I don't know how to reply. Should we just go
ahead and accept
this?
On another PR regarding the packing of rainprod and evapprod I have not
been able to
run with configure -D with GNU yet. I'm getting a floating point error in
an unexpected
place, the fire plume code, not at all related to the "packaging". If you
still want runs
that pass with configure -D then I'll have to debug the floating point
problem and doubt
that I can get this in before weeks end. My feeling is that the packaging
can be done
later.
Stacy
…On Tue, Nov 6, 2018 at 10:08 AM Dave Gill ***@***.***> wrote:
@stacywalters <https://github.com/stacywalters>
Stacy,
We'd like to get the v4.0.2 out this week. Ravan said that he sent this
mod over to Mary earlier, so both Ravan and Ka Yee are OK with this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#677 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIHAksyFxHDU8Po4KszeQJ6ICLMT2A1Xks5uscIGgaJpZM4X5H5q>
.
|
|
Dave,
The scientists have given the green light. Do I need to "approve" this PR?
If so anything tricky in the process or is it as simple as mashing the
approve
button?
Stacy
…On Tue, Nov 6, 2018 at 10:08 AM Dave Gill ***@***.***> wrote:
@stacywalters <https://github.com/stacywalters>
Stacy,
We'd like to get the v4.0.2 out this week. Ravan said that he sent this
mod over to Mary earlier, so both Ravan and Ka Yee are OK with this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#677 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIHAksyFxHDU8Po4KszeQJ6ICLMT2A1Xks5uscIGgaJpZM4X5H5q>
.
|
|
@stacywalters |
stacywalters
approved these changes
Nov 6, 2018
weiwangncar
pushed a commit
that referenced
this pull request
Oct 10, 2024
) TYPE: bug fix KEYWORDS: WRF-Chem, GOCART, optical properties, dust, sea salt, AOD SOURCE: KAUST DESCRIPTION OF CHANGES: Problem: It was found that WRF-Chem with GOCART aerosol scheme disregards the radiative effect of the largest dust and sea salt particles (5th and 4th bins). Solution: Mass redistribution between GOCART dust/sea salt and MOZAIC bins now accounts for the 5th dust and 4th sea salt bins. The number of MOZAIC bins was changed from 8 to 9 and MOZAIC max size range was increased from 10 to 20 um. This PR is an addition to #667 and #677 PR. LIST OF MODIFIED FILES: M chem/module_optical_averaging.F M chem/optical_driver.F TESTS CONDUCTED: - 7-day WRF-Chem run over the Middle East with the GOCART aerosol scheme was conducted without the changes and with changes. As expected, AOD increased by 3% on average. Over dust source regions the AOD increase is more pronounced - 5% on average. See PR itself for details. - The Jenkins tests are all passing. RELEASE NOTE: Bug fix in the calculation of optical properties. Mass redistribution between GOCART dust/sea salt and MOZAIC bins was corrected. It slightly increased (by 3-5%) the aerosol optical depth (AOD).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: optical_prep_gocart, volume-averaged refractive index, mass redistribution, AOD, WRF-Chem
SOURCE: Alexander Ukhov, KAUST
DESCRIPTION OF CHANGES:
Problem: There is a code in optical_prep_gocart procedure which calculates the contribution of the dust and sea salt bins into the MOZAIC bins. The code uses the interpolation over the linear axis but should use the interpolation over log axis. The similar bug was fixed In #536 "fixed coefficients for calculation of PM10 and PM2.5. For GOCART aerosol scheme".
Solution: use interpolation over the log axis instead of linear axis.
Effect: Interpolation over log axis changes the mass redistribution between the MOZAIC bins.
It leads to the increased contribution of the small dust and sea salt particles into the Aerosol Optical Depth (AOD). As a result of the correction, AOD is increasing.
DUST_1..5 are GOCART dust bins
MOZ0...7 are MOZAIC bins
dustfrc_goc8bin BEFORE THE CORRECTION:
dustfrc_goc8bin AFTER THE CORRECTION:
LIST OF MODIFIED FILES: M chem/module_optical_averaging.F
TESTS CONDUCTED:
The test case was run. The obtained result is expected: the AOD level has increased.