Skip to content

Implement the latest CRTM REL-2.2.3 in WRFDA #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 2, 2016

Conversation

jamiebresch
Copy link
Contributor

@jamiebresch jamiebresch commented Nov 29, 2016

TYPE: enhancement

KEYWORDS: WRFDA, CRTM, REL-2.2.3

SOURCE: internal

DESCRIPTION OF CHANGES:

  1. Add pristine CRTM REL-2.2.3.
    After untarring the source file
    ftp://ftp.emc.ncep.noaa.gov/jcsda/CRTM/REL-2.2.3/crtm_v2.2.3.tar.gz,
    (1) rename the directory from REL-2.2.3 to crtm_2.2.3,
    (2) remove the fix directory,
    (3) remove the libsrc/test directory.
    (4) remove unused files for non-WRFDA build mechanism
    The CRTM changes are described in var/external/crtm_2.2.3/crtm_release_notes.txt

  2. Make WRFDA compile with crtm_2.2.3 and
    have crtm_2.2.3 use the same compilation flags as in configure.wrf
    (the reason is to avoid maintaining another set of compiling options
    in var/external/crtm_2.2.3/config-setup where only a subset of WRFDA supported
    compilers are included by default).
    (1) Change crtm_2.1.3 to crtm_2.2.3 in top-level Makefile and compile.
    (2) Change crtm_2.1.3 to crtm_2.2.3 in var/Makefile to have ./clean -a work.
    (3) Add makefile in var/external/crtm_2.2.3 and var/external/crtm_2.2.3/libsrc
    (4) Apply previous in-house crtm-2.1.3 fixes for older compilers.
    M var/external/crtm_2.2.3/libsrc/CRTM_Surface_Define.f90
    M var/external/crtm_2.2.3/libsrc/NLTECoeff_Define.f90

  3. Add "RECORDLENGTH = -assume byterecl" in arch/configure_new.defaults for ifort stanzas.
    It has no impact. The flag is only used for compiling CRTM.
    CRTM requires the flag -assume byterecl for Intel compilers
    because of the direct access read of a long integer in
    Binary_File_Utility.f90.

  4. This is the first stage of the CRTM update.
    (1) After more tests, the older crtm_2.1.3 libs and coefficient files will be removed.
    (2) Overcast radiance is available with a different output name than what was implemented
    in-house previously for cloud detection applications. The related code is enclosed in
    #ifdef CRTM_MODIF and needs to be updated/cleaned up later.

LIST OF MODIFIED FILES:
M Makefile
M arch/configure_new.defaults
M compile
M var/Makefile
A var/external/crtm_2.2.3 (a bunch of files in the dir)
A var/run/crtm_coeffs_2.2.3 (a bunch of files in the dir)

TESTS CONDUCTED:

  1. Mike tested that the code compiled with the following compilers.
    GNU 4.8.2, 5.3.0, 6.1.0
    Intel 12.1.5, 15.0.3. 16.0.2
    PGI 13.3
  2. WRFDA regtest radiance cases show different results as expected.
  3. Larger differences are seen with Intel compilers because of the -fp-model flag.
    crtm_2.1.3 has no -fp-model flag. crtm_2.2.3 uses -fp-model source by default.
    WRFDA uses -fp-model precise.
    -fp-model source and -fp-model precise give identical results.

After untarring the source file
ftp://ftp.emc.ncep.noaa.gov/jcsda/CRTM/REL-2.2.3/crtm_v2.2.3.tar.gz,
1) rename the directory from REL-2.2.3 to crtm_2.2.3,
2) remove the fix directory,
3) remove the libsrc/test directory.
1. Change crtm_2.1.3 to crtm_2.2.3 in top-level Makefile and compile.
2. Add makefile in var/external/crtm_2.2.3 and var/external/crtm_2.2.3/libsrc
3. Remove unused files for other building mechanism
apply previous crtm-2.1.3 fixes for older compilers.

M       Makefile
M       compile
M       var/external/crtm_2.2.3/libsrc/CRTM_Surface_Define.f90
M       var/external/crtm_2.2.3/libsrc/NLTECoeff_Define.f90
M       var/external/crtm_2.2.3/libsrc/makefile
…rly.

CRTM requires the flag -assume byterecl for Intel compilers
because of the direct access read of a long integer in
Binary_File_Utility.f90.

RECORDLENGTH    =       -assume byterecl
is added in arch/configure_new.defaults for ifort stanzas.
The flag is only used for compiling CRTM.

M       arch/configure_new.defaults
M       var/external/crtm_2.2.3/libsrc/makefile
Copy link
Contributor

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by dev committee

@jamiebresch jamiebresch merged commit ecdd5a1 into wrf-model:master Dec 2, 2016
@jamiebresch jamiebresch deleted the wrfda_crtm223_step1 branch December 2, 2016 22:19
jjguerrette pushed a commit to jjguerrette/WRF-public that referenced this pull request Sep 12, 2018
Additionally:
 + Copy var/external/crtm_2.2.3/makefile and libsrc/makefile to new var/external/crtm_2.3.0 subdirectory
 + Update top-level Makefile and compile

Following steps described in PR wrf-model#45

 Changes to be committed:
	modified:   Makefile
	modified:   compile
	new file:   var/external/crtm_2.3.0/README
	new file:   var/external/crtm_2.3.0/config-setup/ftn.setup
	new file:   var/external/crtm_2.3.0/config-setup/ftn.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/g95-debug.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/g95.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/gfortran-debug.setup
	new file:   var/external/crtm_2.3.0/config-setup/gfortran-debug.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/gfortran.setup
	new file:   var/external/crtm_2.3.0/config-setup/gfortran.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/ifort-debug.setup
	new file:   var/external/crtm_2.3.0/config-setup/ifort-debug.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/ifort.setup
	new file:   var/external/crtm_2.3.0/config-setup/ifort.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/pgf95-debug.setup
	new file:   var/external/crtm_2.3.0/config-setup/pgf95-debug.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/pgf95.setup
	new file:   var/external/crtm_2.3.0/config-setup/pgf95.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/xlf2003-debug.setup
	new file:   var/external/crtm_2.3.0/config-setup/xlf2003-debug.setup.csh
	new file:   var/external/crtm_2.3.0/config-setup/xlf2003.setup
	new file:   var/external/crtm_2.3.0/config-setup/xlf2003.setup.csh
	new file:   var/external/crtm_2.3.0/crtm_release_notes.txt
	new file:   var/external/crtm_2.3.0/libsrc/ACCoeff_Binary_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/ACCoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/ADA_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/AOvar_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/ASvar_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/AerosolCoeff_Binary_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/AerosolCoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Azimuth_Emissivity_F6_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/Azimuth_Emissivity_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/Binary_File_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_AOD_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Adjoint_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_AerosolCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_AerosolScatter.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Aerosol_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_AncillaryInput_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_AntennaCorrection.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_AtmAbsorption.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_AtmOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_AtmOptics_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Atmosphere.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Atmosphere_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_ChannelInfo_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_CloudCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_CloudCover_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_CloudScatter.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Cloud_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Fastem1.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_FastemX.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Forward_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_GeometryInfo.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_GeometryInfo_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Geometry_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IRSSEM.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IR_Ice_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IR_Land_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IR_Snow_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IR_Water_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IRiceCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IRlandCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IRsnowCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_IRwaterCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Interpolation.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_K_Matrix_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_LifeCycle.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_LowFrequency_MWSSEM.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_MW_Ice_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_MW_Land_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_MW_Snow_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_MW_Water_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_MWwaterCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Model_Profiles.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Module.fpp
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_MoleculeScatter.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_NLTECorrection.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Options_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Parameters.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Planck_Functions.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Predictor.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Predictor_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_RTSolution.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_RTSolution_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_SEcategory.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_SensorData_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_SensorInfo.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_SfcOptics_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_SpcCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Surface_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Tangent_Linear_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_TauCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_VIS_Ice_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_VIS_Land_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_VIS_Snow_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_VIS_Water_SfcOptics.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_VISiceCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_VISlandCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_VISsnowCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_VISwaterCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/CRTM_Version.inc
	new file:   var/external/crtm_2.3.0/libsrc/CSvar_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/CloudCoeff_Binary_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/CloudCoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Common_RTSolution.f90
	new file:   var/external/crtm_2.3.0/libsrc/Compare_Float_Numbers.f90
	new file:   var/external/crtm_2.3.0/libsrc/DateTime_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/Date_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/Ellison.f90
	new file:   var/external/crtm_2.3.0/libsrc/Emission_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/Endian_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/File_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/FitCoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/FitCoeff_Destroy.inc
	new file:   var/external/crtm_2.3.0/libsrc/FitCoeff_Equal.inc
	new file:   var/external/crtm_2.3.0/libsrc/FitCoeff_Info.inc
	new file:   var/external/crtm_2.3.0/libsrc/FitCoeff_ReadFile.inc
	new file:   var/external/crtm_2.3.0/libsrc/FitCoeff_SetValue.inc
	new file:   var/external/crtm_2.3.0/libsrc/FitCoeff_WriteFile.inc
	new file:   var/external/crtm_2.3.0/libsrc/Foam_Utility_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/Fresnel.f90
	new file:   var/external/crtm_2.3.0/libsrc/Fundamental_Constants.f90
	new file:   var/external/crtm_2.3.0/libsrc/Guillou.f90
	new file:   var/external/crtm_2.3.0/libsrc/Hyperbolic_Step.f90
	new file:   var/external/crtm_2.3.0/libsrc/IRwaterCoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/LSEatlas_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Large_Scale_Correction_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/Liu.f90
	new file:   var/external/crtm_2.3.0/libsrc/MWwaterCoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/MWwaterLUT_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Message_Handler.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_AMSRE_SICEEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_AMSRE_SNOWEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_AMSU_SICEEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_AMSU_SnowEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_ATMS_SeaICE_LIB.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_ATMS_SeaICE_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_ATMS_SnowEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_LandEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_MHS_SICEEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_MHS_SnowEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_SEAICE_PHYEM_MODULE.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_SSMIS_SeaIceEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_SSMIS_SnowEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_SSMI_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_SSMI_SIceEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_SSMI_SnowEM_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_SnowEM_ATMS_Parameters.f90
	new file:   var/external/crtm_2.3.0/libsrc/NESDIS_SnowEM_Parameters.f90
	new file:   var/external/crtm_2.3.0/libsrc/NLTECoeff_Binary_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/NLTECoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/NLTE_Parameters.f90
	new file:   var/external/crtm_2.3.0/libsrc/NLTE_Predictor_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/NLTE_Predictor_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODAS_AtmAbsorption.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODAS_Binary_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODAS_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODAS_Predictor.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODAS_Predictor_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODAS_TauCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODPS_AtmAbsorption.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODPS_Binary_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODPS_CoordinateMapping.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODPS_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODPS_Predictor.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODPS_Predictor_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODPS_TauCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODSSU_AtmAbsorption.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODSSU_Binary_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODSSU_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODSSU_TauCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODZeeman_AtmAbsorption.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODZeeman_Predictor.f90
	new file:   var/external/crtm_2.3.0/libsrc/ODZeeman_TauCoeff.f90
	new file:   var/external/crtm_2.3.0/libsrc/PAFV_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Profile_Utility_Parameters.f90
	new file:   var/external/crtm_2.3.0/libsrc/RTV_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Reflection_Correction_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/SEcategory_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/SOI_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/SSU_Input_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Search_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/SensorInfo_Parameters.f90
	new file:   var/external/crtm_2.3.0/libsrc/Slope_Variance.f90
	new file:   var/external/crtm_2.3.0/libsrc/Small_Scale_Correction_Module.f90
	new file:   var/external/crtm_2.3.0/libsrc/Sort_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/SpcCoeff_Binary_IO.f90
	new file:   var/external/crtm_2.3.0/libsrc/SpcCoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Spectral_Units_Conversion.f90
	new file:   var/external/crtm_2.3.0/libsrc/String_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/Subset_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/TauCoeff_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Timing_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/Type_Kinds.f90
	new file:   var/external/crtm_2.3.0/libsrc/UnitTest_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Zeeman_Input_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/Zeeman_Utility.f90
	new file:   var/external/crtm_2.3.0/libsrc/iAtm_Define.f90
	new file:   var/external/crtm_2.3.0/libsrc/make.dependencies
	new file:   var/external/crtm_2.3.0/libsrc/make.filelist
	new file:   var/external/crtm_2.3.0/libsrc/makefile
	new file:   var/external/crtm_2.3.0/makefile
jjguerrette pushed a commit that referenced this pull request Sep 14, 2018
TYPE: enhancement

KEYWORDS: CRTM, radiance, DA, RTM

SOURCE: internal

DESCRIPTION OF CHANGES: WRFDA carries the CRTM source code, nearly unmodified from the release version from JCDSA.  This PR upgrades that code base from v2.2.3 to v2.3.0, including the set of coefficient files (var/run/crtm_coeffs) stored on Cheyenne.  This upgrade is necessary for using CRTM to simulate GOES-16 ABI radiances, and also keeps WRFDA up to date.

1. This upgrade required
 - Copying var/external/crtm_2.2.3/makefile and var/external/crtm_2.2.3/libsrc/makefile to the new var/external/crtm_2.3.0 subdirectory.
 - Updating the top-level WRFDA Makefile and compile files.

Those steps followed the procedures laid out in PR #45.

2. Some modification of CRTMv2.3.0 source code was required, which followed procedures used for CRTM 2.2.3 described in PR's #58, #214, and #229 for these files:
var/external/crtm_2.3.0/libsrc/CRTM_Adjoint_Module.f90
var/external/crtm_2.3.0/libsrc/CRTM_AtmOptics_Define.f90
var/external/crtm_2.3.0/libsrc/CRTM_Forward_Module.f90
var/external/crtm_2.3.0/libsrc/CRTM_K_Matrix_Module.f90
var/external/crtm_2.3.0/libsrc/CRTM_RTSolution_Define.f90
var/external/crtm_2.3.0/libsrc/CRTM_Tangent_Linear_Module.f90

3. Finally, the new CRTM Cloud Cover code (var/external/crtm_2.3.0/libsrc/CRTM_CloudCover_Define.f90) was modified following instructions from Ben Johnson at JCSDA to fix GNU compilation:
>In "CRTM_CloudCover_Define.f90" you'll find the following lines:
>Line 1356
>     CLASS(CRTM_CloudCover_type), INTENT(OUT) :: self
>Line 1361
>     CLASS(iVar_type), INTENT(OUT) :: self
>Line 1429
>     CLASS(CRTM_CloudCover_type), INTENT(OUT) :: self
>Line 1483
>     CLASS(iVar_type)      , INTENT(OUT) :: self
>
>In these 4 spots, change these INTENT(OUT) to INTENT(INOUT).

LIST OF MODIFIED FILES: 
M	Makefile
M	compile
D	var/external/crtm_2.2.3/config-setup/g95.setup
D	var/external/crtm_2.2.3/crtm_release_notes.txt
D	var/external/crtm_2.2.3/libsrc/CRTM_Version.inc
D	var/external/crtm_2.2.3/libsrc/UnitTest_Define.f90
R091	var/external/crtm_2.2.3/README	var/external/crtm_2.3.0/README
R056	var/external/crtm_2.2.3/config-setup/g95-debug.setup	var/external/crtm_2.3.0/config-setup/ftn.setup
A	var/external/crtm_2.3.0/config-setup/ftn.setup.csh
R100	var/external/crtm_2.2.3/config-setup/g95-debug.setup.csh	var/external/crtm_2.3.0/config-setup/g95-debug.setup.csh
R100	var/external/crtm_2.2.3/config-setup/g95.setup.csh	var/external/crtm_2.3.0/config-setup/g95.setup.csh
R097	var/external/crtm_2.2.3/config-setup/gfortran-debug.setup	var/external/crtm_2.3.0/config-setup/gfortran-debug.setup
R090	var/external/crtm_2.2.3/config-setup/gfortran-debug.setup.csh	var/external/crtm_2.3.0/config-setup/gfortran-debug.setup.csh
R097	var/external/crtm_2.2.3/config-setup/gfortran.setup	var/external/crtm_2.3.0/config-setup/gfortran.setup
R096	var/external/crtm_2.2.3/config-setup/gfortran.setup.csh	var/external/crtm_2.3.0/config-setup/gfortran.setup.csh
R090	var/external/crtm_2.2.3/config-setup/ifort-debug.setup	var/external/crtm_2.3.0/config-setup/ifort-debug.setup
R071	var/external/crtm_2.2.3/config-setup/ifort-debug.setup.csh	var/external/crtm_2.3.0/config-setup/ifort-debug.setup.csh
R090	var/external/crtm_2.2.3/config-setup/ifort.setup	var/external/crtm_2.3.0/config-setup/ifort.setup
R078	var/external/crtm_2.2.3/config-setup/ifort.setup.csh	var/external/crtm_2.3.0/config-setup/ifort.setup.csh
R100	var/external/crtm_2.2.3/config-setup/pgf95-debug.setup	var/external/crtm_2.3.0/config-setup/pgf95-debug.setup
R100	var/external/crtm_2.2.3/config-setup/pgf95-debug.setup.csh	var/external/crtm_2.3.0/config-setup/pgf95-debug.setup.csh
R100	var/external/crtm_2.2.3/config-setup/pgf95.setup	var/external/crtm_2.3.0/config-setup/pgf95.setup
R100	var/external/crtm_2.2.3/config-setup/pgf95.setup.csh	var/external/crtm_2.3.0/config-setup/pgf95.setup.csh
R095	var/external/crtm_2.2.3/config-setup/xlf2003-debug.setup	var/external/crtm_2.3.0/config-setup/xlf2003-debug.setup
R085	var/external/crtm_2.2.3/config-setup/xlf2003-debug.setup.csh	var/external/crtm_2.3.0/config-setup/xlf2003-debug.setup.csh
R095	var/external/crtm_2.2.3/config-setup/xlf2003.setup	var/external/crtm_2.3.0/config-setup/xlf2003.setup
R084	var/external/crtm_2.2.3/config-setup/xlf2003.setup.csh	var/external/crtm_2.3.0/config-setup/xlf2003.setup.csh
A	var/external/crtm_2.3.0/crtm_release_notes.txt
R099	var/external/crtm_2.2.3/libsrc/ACCoeff_Binary_IO.f90	var/external/crtm_2.3.0/libsrc/ACCoeff_Binary_IO.f90
R099	var/external/crtm_2.2.3/libsrc/ACCoeff_Define.f90	var/external/crtm_2.3.0/libsrc/ACCoeff_Define.f90
R099	var/external/crtm_2.2.3/libsrc/ADA_Module.f90	var/external/crtm_2.3.0/libsrc/ADA_Module.f90
R099	var/external/crtm_2.2.3/libsrc/AOvar_Define.f90	var/external/crtm_2.3.0/libsrc/AOvar_Define.f90
R099	var/external/crtm_2.2.3/libsrc/ASvar_Define.f90	var/external/crtm_2.3.0/libsrc/ASvar_Define.f90
R099	var/external/crtm_2.2.3/libsrc/AerosolCoeff_Binary_IO.f90	var/external/crtm_2.3.0/libsrc/AerosolCoeff_Binary_IO.f90
R099	var/external/crtm_2.2.3/libsrc/AerosolCoeff_Define.f90	var/external/crtm_2.3.0/libsrc/AerosolCoeff_Define.f90
R099	var/external/crtm_2.2.3/libsrc/Azimuth_Emissivity_F6_Module.f90	var/external/crtm_2.3.0/libsrc/Azimuth_Emissivity_F6_Module.f90
R099	var/external/crtm_2.2.3/libsrc/Azimuth_Emissivity_Module.f90	var/external/crtm_2.3.0/libsrc/Azimuth_Emissivity_Module.f90
R099	var/external/crtm_2.2.3/libsrc/Binary_File_Utility.f90	var/external/crtm_2.3.0/libsrc/Binary_File_Utility.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_AOD_Module.f90	var/external/crtm_2.3.0/libsrc/CRTM_AOD_Module.f90
R060	var/external/crtm_2.2.3/libsrc/CRTM_Adjoint_Module.f90	var/external/crtm_2.3.0/libsrc/CRTM_Adjoint_Module.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_AerosolCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_AerosolCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_AerosolScatter.f90	var/external/crtm_2.3.0/libsrc/CRTM_AerosolScatter.f90
R095	var/external/crtm_2.2.3/libsrc/CRTM_Aerosol_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_Aerosol_Define.f90
R090	var/external/crtm_2.2.3/libsrc/CRTM_AncillaryInput_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_AncillaryInput_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_AntennaCorrection.f90	var/external/crtm_2.3.0/libsrc/CRTM_AntennaCorrection.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_AtmAbsorption.f90	var/external/crtm_2.3.0/libsrc/CRTM_AtmAbsorption.f90
R067	var/external/crtm_2.2.3/libsrc/CRTM_AtmOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_AtmOptics.f90
R092	var/external/crtm_2.2.3/libsrc/CRTM_AtmOptics_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_AtmOptics_Define.f90
R052	var/external/crtm_2.2.3/libsrc/CRTM_Atmosphere.f90	var/external/crtm_2.3.0/libsrc/CRTM_Atmosphere.f90
R091	var/external/crtm_2.2.3/libsrc/CRTM_Atmosphere_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_Atmosphere_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_ChannelInfo_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_ChannelInfo_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_CloudCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_CloudCoeff.f90
A	var/external/crtm_2.3.0/libsrc/CRTM_CloudCover_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_CloudScatter.f90	var/external/crtm_2.3.0/libsrc/CRTM_CloudScatter.f90
R094	var/external/crtm_2.2.3/libsrc/CRTM_Cloud_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_Cloud_Define.f90
R100	var/external/crtm_2.2.3/libsrc/CRTM_Fastem1.f90	var/external/crtm_2.3.0/libsrc/CRTM_Fastem1.f90
R098	var/external/crtm_2.2.3/libsrc/CRTM_FastemX.f90	var/external/crtm_2.3.0/libsrc/CRTM_FastemX.f90
R070	var/external/crtm_2.2.3/libsrc/CRTM_Forward_Module.f90	var/external/crtm_2.3.0/libsrc/CRTM_Forward_Module.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_GeometryInfo.f90	var/external/crtm_2.3.0/libsrc/CRTM_GeometryInfo.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_GeometryInfo_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_GeometryInfo_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_Geometry_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_Geometry_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IRSSEM.f90	var/external/crtm_2.3.0/libsrc/CRTM_IRSSEM.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IR_Ice_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_IR_Ice_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IR_Land_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_IR_Land_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IR_Snow_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_IR_Snow_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IR_Water_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_IR_Water_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IRiceCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_IRiceCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IRlandCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_IRlandCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IRsnowCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_IRsnowCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_IRwaterCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_IRwaterCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_Interpolation.f90	var/external/crtm_2.3.0/libsrc/CRTM_Interpolation.f90
R060	var/external/crtm_2.2.3/libsrc/CRTM_K_Matrix_Module.f90	var/external/crtm_2.3.0/libsrc/CRTM_K_Matrix_Module.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_LifeCycle.f90	var/external/crtm_2.3.0/libsrc/CRTM_LifeCycle.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_LowFrequency_MWSSEM.f90	var/external/crtm_2.3.0/libsrc/CRTM_LowFrequency_MWSSEM.f90
R093	var/external/crtm_2.2.3/libsrc/CRTM_MW_Ice_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_MW_Ice_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_MW_Land_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_MW_Land_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_MW_Snow_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_MW_Snow_SfcOptics.f90
R097	var/external/crtm_2.2.3/libsrc/CRTM_MW_Water_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_MW_Water_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_MWwaterCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_MWwaterCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_Model_Profiles.f90	var/external/crtm_2.3.0/libsrc/CRTM_Model_Profiles.f90
R095	var/external/crtm_2.2.3/libsrc/CRTM_Module.fpp	var/external/crtm_2.3.0/libsrc/CRTM_Module.fpp
R099	var/external/crtm_2.2.3/libsrc/CRTM_MoleculeScatter.f90	var/external/crtm_2.3.0/libsrc/CRTM_MoleculeScatter.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_NLTECorrection.f90	var/external/crtm_2.3.0/libsrc/CRTM_NLTECorrection.f90
R067	var/external/crtm_2.2.3/libsrc/CRTM_Options_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_Options_Define.f90
R100	var/external/crtm_2.2.3/libsrc/CRTM_Parameters.f90	var/external/crtm_2.3.0/libsrc/CRTM_Parameters.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_Planck_Functions.f90	var/external/crtm_2.3.0/libsrc/CRTM_Planck_Functions.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_Predictor.f90	var/external/crtm_2.3.0/libsrc/CRTM_Predictor.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_Predictor_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_Predictor_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_RTSolution.f90	var/external/crtm_2.3.0/libsrc/CRTM_RTSolution.f90
R087	var/external/crtm_2.2.3/libsrc/CRTM_RTSolution_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_RTSolution_Define.f90
R098	var/external/crtm_2.2.3/libsrc/CRTM_SEcategory.f90	var/external/crtm_2.3.0/libsrc/CRTM_SEcategory.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_SensorData_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_SensorData_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_SensorInfo.f90	var/external/crtm_2.3.0/libsrc/CRTM_SensorInfo.f90
R098	var/external/crtm_2.2.3/libsrc/CRTM_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_SfcOptics.f90
R062	var/external/crtm_2.2.3/libsrc/CRTM_SfcOptics_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_SfcOptics_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_SpcCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_SpcCoeff.f90
R097	var/external/crtm_2.2.3/libsrc/CRTM_Surface_Define.f90	var/external/crtm_2.3.0/libsrc/CRTM_Surface_Define.f90
R068	var/external/crtm_2.2.3/libsrc/CRTM_Tangent_Linear_Module.f90	var/external/crtm_2.3.0/libsrc/CRTM_Tangent_Linear_Module.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_TauCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_TauCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_Utility.f90	var/external/crtm_2.3.0/libsrc/CRTM_Utility.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_VIS_Ice_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_VIS_Ice_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_VIS_Land_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_VIS_Land_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_VIS_Snow_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_VIS_Snow_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_VIS_Water_SfcOptics.f90	var/external/crtm_2.3.0/libsrc/CRTM_VIS_Water_SfcOptics.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_VISiceCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_VISiceCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_VISlandCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_VISlandCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_VISsnowCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_VISsnowCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/CRTM_VISwaterCoeff.f90	var/external/crtm_2.3.0/libsrc/CRTM_VISwaterCoeff.f90
A	var/external/crtm_2.3.0/libsrc/CRTM_Version.inc
R099	var/external/crtm_2.2.3/libsrc/CSvar_Define.f90	var/external/crtm_2.3.0/libsrc/CSvar_Define.f90
R099	var/external/crtm_2.2.3/libsrc/CloudCoeff_Binary_IO.f90	var/external/crtm_2.3.0/libsrc/CloudCoeff_Binary_IO.f90
R099	var/external/crtm_2.2.3/libsrc/CloudCoeff_Define.f90	var/external/crtm_2.3.0/libsrc/CloudCoeff_Define.f90
R099	var/external/crtm_2.2.3/libsrc/Common_RTSolution.f90	var/external/crtm_2.3.0/libsrc/Common_RTSolution.f90
R095	var/external/crtm_2.2.3/libsrc/Compare_Float_Numbers.f90	var/external/crtm_2.3.0/libsrc/Compare_Float_Numbers.f90
R099	var/external/crtm_2.2.3/libsrc/DateTime_Utility.f90	var/external/crtm_2.3.0/libsrc/DateTime_Utility.f90
R099	var/external/crtm_2.2.3/libsrc/Date_Utility.f90	var/external/crtm_2.3.0/libsrc/Date_Utility.f90
R099	var/external/crtm_2.2.3/libsrc/Ellison.f90	var/external/crtm_2.3.0/libsrc/Ellison.f90
R100	var/external/crtm_2.2.3/libsrc/Emission_Module.f90	var/external/crtm_2.3.0/libsrc/Emission_Module.f90
R099	var/external/crtm_2.2.3/libsrc/Endian_Utility.f90	var/external/crtm_2.3.0/libsrc/Endian_Utility.f90
R099	var/external/crtm_2.2.3/libsrc/File_Utility.f90	var/external/crtm_2.3.0/libsrc/File_Utility.f90
R099	var/external/crtm_2.2.3/libsrc/FitCoeff_Define.f90	var/external/crtm_2.3.0/libsrc/FitCoeff_Define.f90
R100	var/external/crtm_2.2.3/libsrc/FitCoeff_Destroy.inc	var/external/crtm_2.3.0/libsrc/FitCoeff_Destroy.inc
R100	var/external/crtm_2.2.3/libsrc/FitCoeff_Equal.inc	var/external/crtm_2.3.0/libsrc/FitCoeff_Equal.inc
R100	var/external/crtm_2.2.3/libsrc/FitCoeff_Info.inc	var/external/crtm_2.3.0/libsrc/FitCoeff_Info.inc
R100	var/external/crtm_2.2.3/libsrc/FitCoeff_ReadFile.inc	var/external/crtm_2.3.0/libsrc/FitCoeff_ReadFile.inc
R100	var/external/crtm_2.2.3/libsrc/FitCoeff_SetValue.inc	var/external/crtm_2.3.0/libsrc/FitCoeff_SetValue.inc
R100	var/external/crtm_2.2.3/libsrc/FitCoeff_WriteFile.inc	var/external/crtm_2.3.0/libsrc/FitCoeff_WriteFile.inc
R098	var/external/crtm_2.2.3/libsrc/Foam_Utility_Module.f90	var/external/crtm_2.3.0/libsrc/Foam_Utility_Module.f90
R099	var/external/crtm_2.2.3/libsrc/Fresnel.f90	var/external/crtm_2.3.0/libsrc/Fresnel.f90
R099	var/external/crtm_2.2.3/libsrc/Fundamental_Constants.f90	var/external/crtm_2.3.0/libsrc/Fundamental_Constants.f90
R099	var/external/crtm_2.2.3/libsrc/Guillou.f90	var/external/crtm_2.3.0/libsrc/Guillou.f90
R098	var/external/crtm_2.2.3/libsrc/Hyperbolic_Step.f90	var/external/crtm_2.3.0/libsrc/Hyperbolic_Step.f90
R099	var/external/crtm_2.2.3/libsrc/IRwaterCoeff_Define.f90	var/external/crtm_2.3.0/libsrc/IRwaterCoeff_Define.f90
R099	var/external/crtm_2.2.3/libsrc/LSEatlas_Define.f90	var/external/crtm_2.3.0/libsrc/LSEatlas_Define.f90
R098	var/external/crtm_2.2.3/libsrc/Large_Scale_Correction_Module.f90	var/external/crtm_2.3.0/libsrc/Large_Scale_Correction_Module.f90
R099	var/external/crtm_2.2.3/libsrc/Liu.f90	var/external/crtm_2.3.0/libsrc/Liu.f90
R099	var/external/crtm_2.2.3/libsrc/MWwaterCoeff_Define.f90	var/external/crtm_2.3.0/libsrc/MWwaterCoeff_Define.f90
R099	var/external/crtm_2.2.3/libsrc/MWwaterLUT_Define.f90	var/external/crtm_2.3.0/libsrc/MWwaterLUT_Define.f90
R100	var/external/crtm_2.2.3/libsrc/Message_Handler.f90	var/external/crtm_2.3.0/libsrc/Message_Handler.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_AMSRE_SICEEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_AMSRE_SICEEM_Module.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_AMSRE_SNOWEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_AMSRE_SNOWEM_Module.f90
R093	var/external/crtm_2.2.3/libsrc/NESDIS_AMSU_SICEEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_AMSU_SICEEM_Module.f90
R089	var/external/crtm_2.2.3/libsrc/NESDIS_AMSU_SnowEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_AMSU_SnowEM_Module.f90
A	var/external/crtm_2.3.0/libsrc/NESDIS_ATMS_SeaICE_LIB.f90
A	var/external/crtm_2.3.0/libsrc/NESDIS_ATMS_SeaICE_Module.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_ATMS_SnowEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_ATMS_SnowEM_Module.f90
R100	var/external/crtm_2.2.3/libsrc/NESDIS_LandEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_LandEM_Module.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_MHS_SICEEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_MHS_SICEEM_Module.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_MHS_SnowEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_MHS_SnowEM_Module.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_SEAICE_PHYEM_MODULE.f90	var/external/crtm_2.3.0/libsrc/NESDIS_SEAICE_PHYEM_MODULE.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_SSMIS_SeaIceEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_SSMIS_SeaIceEM_Module.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_SSMIS_SnowEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_SSMIS_SnowEM_Module.f90
R091	var/external/crtm_2.2.3/libsrc/NESDIS_SSMI_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_SSMI_Module.f90
R094	var/external/crtm_2.2.3/libsrc/NESDIS_SSMI_SIceEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_SSMI_SIceEM_Module.f90
R094	var/external/crtm_2.2.3/libsrc/NESDIS_SSMI_SnowEM_Module.f90	var/external/crtm_2.3.0/libsrc/NESDIS_SSMI_SnowEM_Module.f90
R100	var/external/crtm_2.2.3/libsrc/NESDIS_SnowEM_ATMS_Parameters.f90	var/external/crtm_2.3.0/libsrc/NESDIS_SnowEM_ATMS_Parameters.f90
R099	var/external/crtm_2.2.3/libsrc/NESDIS_SnowEM_Parameters.f90	var/external/crtm_2.3.0/libsrc/NESDIS_SnowEM_Parameters.f90
R099	var/external/crtm_2.2.3/libsrc/NLTECoeff_Binary_IO.f90	var/external/crtm_2.3.0/libsrc/NLTECoeff_Binary_IO.f90
R099	var/external/crtm_2.2.3/libsrc/NLTECoeff_Define.f90	var/external/crtm_2.3.0/libsrc/NLTECoeff_Define.f90
R096	var/external/crtm_2.2.3/libsrc/NLTE_Parameters.f90	var/external/crtm_2.3.0/libsrc/NLTE_Parameters.f90
R099	var/external/crtm_2.2.3/libsrc/NLTE_Predictor_Define.f90	var/external/crtm_2.3.0/libsrc/NLTE_Predictor_Define.f90
R099	var/external/crtm_2.2.3/libsrc/NLTE_Predictor_IO.f90	var/external/crtm_2.3.0/libsrc/NLTE_Predictor_IO.f90
R099	var/external/crtm_2.2.3/libsrc/ODAS_AtmAbsorption.f90	var/external/crtm_2.3.0/libsrc/ODAS_AtmAbsorption.f90
R099	var/external/crtm_2.2.3/libsrc/ODAS_Binary_IO.f90	var/external/crtm_2.3.0/libsrc/ODAS_Binary_IO.f90
R099	var/external/crtm_2.2.3/libsrc/ODAS_Define.f90	var/external/crtm_2.3.0/libsrc/ODAS_Define.f90
R099	var/external/crtm_2.2.3/libsrc/ODAS_Predictor.f90	var/external/crtm_2.3.0/libsrc/ODAS_Predictor.f90
R099	var/external/crtm_2.2.3/libsrc/ODAS_Predictor_Define.f90	var/external/crtm_2.3.0/libsrc/ODAS_Predictor_Define.f90
R099	var/external/crtm_2.2.3/libsrc/ODAS_TauCoeff.f90	var/external/crtm_2.3.0/libsrc/ODAS_TauCoeff.f90
R100	var/external/crtm_2.2.3/libsrc/ODPS_AtmAbsorption.f90	var/external/crtm_2.3.0/libsrc/ODPS_AtmAbsorption.f90
R100	var/external/crtm_2.2.3/libsrc/ODPS_Binary_IO.f90	var/external/crtm_2.3.0/libsrc/ODPS_Binary_IO.f90
R099	var/external/crtm_2.2.3/libsrc/ODPS_CoordinateMapping.f90	var/external/crtm_2.3.0/libsrc/ODPS_CoordinateMapping.f90
R100	var/external/crtm_2.2.3/libsrc/ODPS_Define.f90	var/external/crtm_2.3.0/libsrc/ODPS_Define.f90
R100	var/external/crtm_2.2.3/libsrc/ODPS_Predictor.f90	var/external/crtm_2.3.0/libsrc/ODPS_Predictor.f90
R100	var/external/crtm_2.2.3/libsrc/ODPS_Predictor_Define.f90	var/external/crtm_2.3.0/libsrc/ODPS_Predictor_Define.f90
R100	var/external/crtm_2.2.3/libsrc/ODPS_TauCoeff.f90	var/external/crtm_2.3.0/libsrc/ODPS_TauCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/ODSSU_AtmAbsorption.f90	var/external/crtm_2.3.0/libsrc/ODSSU_AtmAbsorption.f90
R099	var/external/crtm_2.2.3/libsrc/ODSSU_Binary_IO.f90	var/external/crtm_2.3.0/libsrc/ODSSU_Binary_IO.f90
R099	var/external/crtm_2.2.3/libsrc/ODSSU_Define.f90	var/external/crtm_2.3.0/libsrc/ODSSU_Define.f90
R099	var/external/crtm_2.2.3/libsrc/ODSSU_TauCoeff.f90	var/external/crtm_2.3.0/libsrc/ODSSU_TauCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/ODZeeman_AtmAbsorption.f90	var/external/crtm_2.3.0/libsrc/ODZeeman_AtmAbsorption.f90
R100	var/external/crtm_2.2.3/libsrc/ODZeeman_Predictor.f90	var/external/crtm_2.3.0/libsrc/ODZeeman_Predictor.f90
R099	var/external/crtm_2.2.3/libsrc/ODZeeman_TauCoeff.f90	var/external/crtm_2.3.0/libsrc/ODZeeman_TauCoeff.f90
R099	var/external/crtm_2.2.3/libsrc/PAFV_Define.f90	var/external/crtm_2.3.0/libsrc/PAFV_Define.f90
R100	var/external/crtm_2.2.3/libsrc/Profile_Utility_Parameters.f90	var/external/crtm_2.3.0/libsrc/Profile_Utility_Parameters.f90
R099	var/external/crtm_2.2.3/libsrc/RTV_Define.f90	var/external/crtm_2.3.0/libsrc/RTV_Define.f90
R099	var/external/crtm_2.2.3/libsrc/Reflection_Correction_Module.f90	var/external/crtm_2.3.0/libsrc/Reflection_Correction_Module.f90
R099	var/external/crtm_2.2.3/libsrc/SEcategory_Define.f90	var/external/crtm_2.3.0/libsrc/SEcategory_Define.f90
R099	var/external/crtm_2.2.3/libsrc/SOI_Module.f90	var/external/crtm_2.3.0/libsrc/SOI_Module.f90
R099	var/external/crtm_2.2.3/libsrc/SSU_Input_Define.f90	var/external/crtm_2.3.0/libsrc/SSU_Input_Define.f90
R098	var/external/crtm_2.2.3/libsrc/Search_Utility.f90	var/external/crtm_2.3.0/libsrc/Search_Utility.f90
R100	var/external/crtm_2.2.3/libsrc/SensorInfo_Parameters.f90	var/external/crtm_2.3.0/libsrc/SensorInfo_Parameters.f90
R098	var/external/crtm_2.2.3/libsrc/Slope_Variance.f90	var/external/crtm_2.3.0/libsrc/Slope_Variance.f90
R098	var/external/crtm_2.2.3/libsrc/Small_Scale_Correction_Module.f90	var/external/crtm_2.3.0/libsrc/Small_Scale_Correction_Module.f90
R100	var/external/crtm_2.2.3/libsrc/Sort_Utility.f90	var/external/crtm_2.3.0/libsrc/Sort_Utility.f90
R099	var/external/crtm_2.2.3/libsrc/SpcCoeff_Binary_IO.f90	var/external/crtm_2.3.0/libsrc/SpcCoeff_Binary_IO.f90
R099	var/external/crtm_2.2.3/libsrc/SpcCoeff_Define.f90	var/external/crtm_2.3.0/libsrc/SpcCoeff_Define.f90
R099	var/external/crtm_2.2.3/libsrc/Spectral_Units_Conversion.f90	var/external/crtm_2.3.0/libsrc/Spectral_Units_Conversion.f90
R099	var/external/crtm_2.2.3/libsrc/String_Utility.f90	var/external/crtm_2.3.0/libsrc/String_Utility.f90
R099	var/external/crtm_2.2.3/libsrc/Subset_Define.f90	var/external/crtm_2.3.0/libsrc/Subset_Define.f90
R099	var/external/crtm_2.2.3/libsrc/TauCoeff_Define.f90	var/external/crtm_2.3.0/libsrc/TauCoeff_Define.f90
R099	var/external/crtm_2.2.3/libsrc/Timing_Utility.f90	var/external/crtm_2.3.0/libsrc/Timing_Utility.f90
R100	var/external/crtm_2.2.3/libsrc/Type_Kinds.f90	var/external/crtm_2.3.0/libsrc/Type_Kinds.f90
A	var/external/crtm_2.3.0/libsrc/UnitTest_Define.f90
R099	var/external/crtm_2.2.3/libsrc/Zeeman_Input_Define.f90	var/external/crtm_2.3.0/libsrc/Zeeman_Input_Define.f90
R100	var/external/crtm_2.2.3/libsrc/Zeeman_Utility.f90	var/external/crtm_2.3.0/libsrc/Zeeman_Utility.f90
R098	var/external/crtm_2.2.3/libsrc/iAtm_Define.f90	var/external/crtm_2.3.0/libsrc/iAtm_Define.f90
R086	var/external/crtm_2.2.3/libsrc/make.dependencies	var/external/crtm_2.3.0/libsrc/make.dependencies
R096	var/external/crtm_2.2.3/libsrc/make.filelist	var/external/crtm_2.3.0/libsrc/make.filelist
R100	var/external/crtm_2.2.3/libsrc/makefile	var/external/crtm_2.3.0/libsrc/makefile
R100	var/external/crtm_2.2.3/makefile	var/external/crtm_2.3.0/makefile
M	var/run/crtm_coeffs

TESTS CONDUCTED: The WRFDA Regression test passes with "match" results except for two of the scenarios (AMSR2 and ASR_airs).  The largest differences are for QVAPOR in the AMSR2 scenario, which we have determined to be reasonable.

>``Diffing amsr2/dmpar/wrfvar_output.Linux.cheyenne.amsr2.dmpar.ifort.17.0.1 /gpfs/p/work/guerrett/wrf/DA/WORKDIRS/REGTEST.V4.CRTMv2.3/BASELINE.NEW/wrfvar_output.Linux.cheyenne.amsr2.dmpar.ifort.17.0.1
 Next Time 2012-10-27_18:00:00
     Field   Ndifs    Dims       RMS (1)            RMS (2)     DIGITS    RMSE     pntwise max
         U   7529529    3   0.1228070331E+02   0.1228018586E+02   4   0.2564E-01   0.2446E-02
         V   7534717    3   0.8894861040E+01   0.8897111227E+01   3   0.2927E-01   0.2876E-02
        PH   7510672    3   0.5396780586E+04   0.5400519475E+04   3   0.1000E+02   0.7443E-02
         T   7508800    3   0.1628846754E+03   0.1628859236E+03   5   0.1584E-01   0.4897E-03
        MU    134128    2   0.1130219291E+04   0.1129215499E+04   3   0.9315E+01   0.2534E-01
         P   7511392    3   0.7161355843E+03   0.7159596821E+03   3   0.2089E+01   0.1358E-01
      PSFC    133725    2   0.9812892707E+05   0.9812897025E+05   6   0.1087E+01   0.3672E-04
    QVAPOR   7150574    3   0.6477450387E-02   0.6532164878E-02   2   0.1219E-03   0.1097E+00
       THM   7508800    3   0.1628846754E+03   0.1628859236E+03   5   0.1584E-01   0.4897E-03``


>``Diffing ASR_airs/dmpar/wrfvar_output.Linux.cheyenne.ASR_airs.dmpar.ifort.17.0.1 /gpfs/p/work/guerrett/wrf/DA/WORKDIRS/REGTEST.V4.CRTMv2.3/BASELINE.NEW/wrfvar_output.Linux.cheyenne.ASR_airs.dmpar.ifort.17.0.1
 Next Time 2007-12-01_00:00:00
     Field   Ndifs    Dims       RMS (1)            RMS (2)     DIGITS    RMSE     pntwise max
         U    441357    3   0.1595920712E+02   0.1595959433E+02   4   0.4183E-02   0.5241E-03
         V    441795    3   0.1532821107E+02   0.1532845654E+02   4   0.4509E-02   0.5063E-03
        PH    436719    3   0.5476526252E+04   0.5479301120E+04   3   0.8178E+01   0.3150E-02
         T    433432    3   0.2024811768E+03   0.2024849600E+03   4   0.2340E-01   0.3896E-03
        MU      6236    2   0.1568993334E+04   0.1568690755E+04   3   0.1599E+01   0.1512E-02
         P    436456    3   0.7302871489E+03   0.7301472112E+03   3   0.6637E+00   0.1234E-02
      PSFC      5872    2   0.9819986247E+05   0.9819913908E+05   5   0.1419E+01   0.5884E-04
    QVAPOR    155535    3   0.3153512003E-02   0.3154235963E-02   3   0.3697E-05   0.4848E-02
       THM    433432    3   0.2024811768E+03   0.2024849600E+03   4   0.2340E-01   0.3896E-03``
dmey pushed a commit to TEB-model/wrf-teb that referenced this pull request Mar 31, 2020
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
fengggli pushed a commit to fengggli/WRF that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants