minor bug in urban module phys/module_sf_bep_bem.F

[LluisFB]

Describe the bug
In subroutine BEP1D (WRF v4.5.1) there is a loop with a too large extent. When compiling the model in debug mode, it crashes with an error message about array over passing.

This is the loop with the issue:

       do iz=1,nz_um !Compute the outdoor temperature 
	 tmp_u(iz)=pt_u(iz)*(pr_u(iz)/p0)**(rcp_u) 
       end do

Solution
The loop should only run up to nzu.

       do iz=1,nzu !Compute the outdoor temperature 
	 tmp_u(iz)=pt_u(iz)*(pr_u(iz)/p0)**(rcp_u) 
       end do

I already modified the code and worked properly.

[weiwangncar]

@cenlinhe Can you take a look at this post? Thanks!

[cenlinhe]

@LluisFB Thank you for reporting this. The code line is here: https://github.com/wrf-model/WRF/blob/master/phys/module_sf_bep_bem.F#L1600-L1602
This bug fix looks good to me. @LluisFB Could you please submit a PR for this bug fix?
@tslin2 could you please also take a look at this?

[LluisFB]

@cenlinhe you very welcome.

I do not want to mess up thinks, when do you ask me to submit a PR, do you mean to create a Pull Request?

If I properly understood I should:
1.- open a branch for my self
2.- Modify the code
3.- Proceed with the pool request via comparing both codes?

[weiwangncar]

You can find instructions on our wiki page: https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification.

[LluisFB]

I think I done it properly following the instructions

[tslin2]

@LluisFB Thank you for reporting this. The code line is here: https://github.com/wrf-model/WRF/blob/master/phys/module_sf_bep_bem.F#L1600-L1602 This bug fix looks good to me. @LluisFB Could you please submit a PR for this bug fix? @tslin2 could you please also take a look at this?

The fix looks good to me. Thanks!