CMake Fix MPI Option Selection #270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that while the typo of the initial variable is fixed, this has no practical effect as the scope of the assigned variable within the if statements extends beyond the control of these blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic is flipped to incorrectly negate user requested configuration. The default
[y/N]prompt is already satisfied by the need to look for explicityesValuesmatches, otherwise anything else (default) isFalse.A minor fix is included for the default initial value of the
useMPIvariable. This has no practical effect, but is a cleanup of poor code style relying on variable scope outside of the if-statement.