Skip to content

Set status merge#1

Merged
wreiske merged 6 commits intowreiske:custom-status-uifrom
Prateek93a:set-status
Jan 25, 2020
Merged

Set status merge#1
wreiske merged 6 commits intowreiske:custom-status-uifrom
Prateek93a:set-status

Conversation

@wreiske
Copy link
Owner

@wreiske wreiske commented Jan 20, 2020

No description provided.

@wreiske
Copy link
Owner Author

wreiske commented Jan 20, 2020

@Prateek93a do you think you could resolve the merge conflicts? Thanks.

@Prateek93a
Copy link

Prateek93a commented Jan 20, 2020

@wreiske Done.

Copy link
Owner Author

@wreiske wreiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to test these changes. I will get it tested in the next few days. Thanks.

@Prateek93a
Copy link

Thank you. Hope you liked my work.

@wreiske
Copy link
Owner Author

wreiske commented Jan 25, 2020

@Prateek93a There is a bug when you update your status on desktop, the modal window text doesn't change.

  1. Change status on mobile app.
  2. Change status on desktop
  3. Tap to change status on mobile app to see the original status message in the modal.

@wreiske wreiske merged commit 673c25f into wreiske:custom-status-ui Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants