refactoring specs for more efficient factories and validations

spec/models/ingredient_spec.rb

@@ -3,8 +3,7 @@
 describe Ingredient do
 
   it 'has a valid factory' do
-    ingredient = FactoryGirl.create(:ingredient)
-    expect(ingredient).to be_valid
+    expect(FactoryGirl.build(:ingredient)).to be_valid
   end
 
   it { should have_many(:step_ingredients) }

spec/models/recipe_spec.rb

@@ -3,8 +3,7 @@
 describe Recipe do
 
   it 'has a valid factory' do
-    recipe = FactoryGirl.create(:recipe)
-    expect(recipe).to be_valid
+    expect(FactoryGirl.build(:recipe)).to be_valid
   end
 
   it { should have_many(:steps) }

spec/models/step_ingredient_spec.rb

@@ -3,18 +3,15 @@
 describe StepIngredient do
 
   it 'has a valid factory' do
-    step_ingredient = FactoryGirl.create(:step_ingredient)
-    expect(step_ingredient).to be_valid
+    expect(FactoryGirl.build(:step_ingredient)).to be_valid
   end
 
   it 'is invalid without a step_id' do
-    step_ingredient = FactoryGirl.build(:step_ingredient, step_id: nil)
-    expect(step_ingredient).to be_invalid
+    expect(FactoryGirl.build(:step_ingredient, step_id: nil)).to be_invalid
   end
 
   it 'is invalid without an ingredient_id' do
-    step_ingredient = FactoryGirl.build(:step_ingredient, ingredient_id: nil)
-    expect(step_ingredient).to be_invalid
+    expect(FactoryGirl.build(:step_ingredient, ingredient_id: nil)).to be_invalid
   end
 
   it { should belong_to(:step) }

spec/models/step_spec.rb

@@ -3,8 +3,7 @@
 describe Step do
 
   it 'has a valid factory' do
-    step = FactoryGirl.create(:step)
-    expect(step).to be_valid
+    expect(FactoryGirl.build(:step)).to be_valid
   end
 
   it { should belong_to(:recipe) }

spec/models/step_tool_spec.rb

@@ -3,18 +3,15 @@
 describe StepTool do
 
   it 'has a valid factory' do
-    step_tool = FactoryGirl.create(:step_tool)
-    expect(step_tool).to be_valid
+    expect(FactoryGirl.build(:step_tool)).to be_valid
   end
 
   it 'is invalid without a step_id' do
-     step_tool = FactoryGirl.build(:step_tool, step_id: nil)
-     expect(step_tool).to be_invalid
-   end
+    expect(FactoryGirl.build(:step_tool, step_id: nil)).to be_invalid
+  end
 
   it 'is invalid without an tool_id' do
-    step_tool = FactoryGirl.build(:step_tool, tool_id: nil)
-    expect(step_tool).to be_invalid
+    expect(FactoryGirl.build(:step_tool, tool_id: nil)).to be_invalid
   end
 
   it { should belong_to(:step) }

spec/models/tool_spec.rb

@@ -3,8 +3,7 @@
 describe Tool do
 
   it 'has a valid factory' do
-    tool = FactoryGirl.create(:tool)
-    expect(tool).to be_valid
+    expect(FactoryGirl.build(:tool)).to be_valid
   end
 
   it { should have_many(:step_tools) }