-
Notifications
You must be signed in to change notification settings - Fork 4
614-add-wrangle-compare-list #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a new compare.lists function for comparing list columns in DataFrames and refactors existing code for improved consistency. The main purpose is to enable flexible list comparison operations (intersection, difference, union, overlap) with configurable options for duplicate removal and case sensitivity.
Key changes:
- Added
listsfunction inwrangles/recipe_wrangles/compare.pysupporting four comparison methods with case sensitivity and duplicate removal options - Created
remove_duplicatesutility function inwrangles/compare.pyto handle duplicate removal logic - Updated code style in existing
textfunction to use consistent double quotes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| wrangles/recipe_wrangles/compare.py | Added new lists function for list comparison and updated text function code style to use double quotes |
| wrangles/compare.py | Added remove_duplicates utility function to support list comparison operations |
| tests/recipes/wrangles/test_compare.py | Added comprehensive test suite for new lists function and updated existing test formatting to use double quotes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This pull request adds a new function for comparing lists in DataFrames and improves the flexibility of existing comparison functions. The main changes introduce a configurable way to compare multiple list columns, including options for intersection, difference, union, and overlap, as well as duplicate and case sensitivity handling. Additionally, minor code style and validation improvements were made to the text comparison function.
New list comparison functionality:
listsfunction towrangles/recipe_wrangles/compare.pyto compare multiple list columns in a DataFrame, supporting intersection, difference, union, and overlap methods, with options to remove duplicates and ignore case.remove_duplicatesutility inwrangles/compare.pyto handle duplicate removal and case sensitivity for list comparisons.