Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing properties in group type definition #2227

Merged
merged 3 commits into from
Aug 5, 2024
Merged

fix: missing properties in group type definition #2227

merged 3 commits into from
Aug 5, 2024

Conversation

gekkedev
Copy link
Contributor

@gekkedev gekkedev commented Jun 18, 2024 •
edited
Loading

Corrected the GroupMetadata interface based on two example groups I retrieved using client.listChats({ onlyGroups: true }).

@icleitoncosta
Copy link
Contributor

Thanks, please change comma for dot and comma

@gekkedev
Copy link
Contributor Author

done @icleitoncosta :-)

@gekkedev
Copy link
Contributor Author

gekkedev commented Jun 20, 2024 •
edited
Loading

I also want to amend the return type of getGroupInfoFromInviteLink, where can I find the type definition? In the repo for wa-js I found 3 similar type definitions but they all had some differences to the return types shipped in the latest version (so I assume those are not the ones I was looking for).

@gekkedev
Copy link
Contributor Author

I also want to amend the return type of getGroupInfoFromInviteLink, where can I find the type definition? In the repo for wa-js I found 3 similar type definitions but they all had some differences to the return types shipped in the latest version (so I assume those are not the ones I was looking for).

@icleitoncosta could you take a look at how I can change this? Got more info to add but I'm a little lost.

@gekkedev gekkedev force-pushed the patch-4 branch 4 times, most recently from 9320262 to a706442 Compare July 23, 2024 11:23
@gekkedev gekkedev changed the title fix: added missing properties to the GroupMetadata interface fix: missing properties in group type definition Jul 23, 2024
@gekkedev
Copy link
Contributor Author

@icleitoncosta I adjusted the commit names

@icleitoncosta icleitoncosta merged commit dca8f1e into wppconnect-team:master Aug 5, 2024
5 checks passed
@devactivity-app devActivity App
Copy link

Pull Request Summary by devActivity

Metrics

Cycle Time: 48d 4h 7m Coding Time: 1m Pickup Time: 14h 23m Review Time: 47d 13h 42m Comments: 2

Achievements

@gekkedev gekkedev deleted the patch-4 branch September 9, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gekkedev @icleitoncosta