-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: bug on footer not fixed in bottom on Simple mPDF and RTL templates #12
Conversation
@alexmigf how do i use this extension? i get a 500 internal error on all the templates including the custom mpdf templates |
@dwalkerpriv after cloning the repository you need to run: |
I notice some other issues, I need to fix those before your reviews. |
@dwalkerpriv you could review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwalkerpriv this PR just fixes the mPDF templates ( Simple mpdf and rtl), the others are on different repositories. |
When I do |
I don't have any issues, please consider removing the directory and clone again. |
@alexmigf I removed the directory and still get the same error. |
@dpeyou remove the directory, update git clone git@github.com:wpovernight/woocommerce-pdf-ips-mpdf.git
cd woocommerce-pdf-ips-mpdf
composer install |
@alexmigf I'm afraid I'm unable to test mPDF. I download the latest binary as described on the composer website, to my home directory using: ....then I call the binary using So I did |
When tested in a new environment, it works properly...so I think I can approve the PR..? |
If you think so :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues encountered in a fresh install 👍
Footer sticks to bottom as in the other templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ LGTM!
closes #7