Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bug on footer not fixed in bottom on Simple mPDF and RTL templates #12

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

alexmigf
Copy link
Member

@alexmigf alexmigf commented Mar 7, 2023

closes #7

@dwalkerpriv
Copy link

@alexmigf how do i use this extension? i get a 500 internal error on all the templates including the custom mpdf templates

@alexmigf
Copy link
Member Author

alexmigf commented Mar 7, 2023

@dwalkerpriv after cloning the repository you need to run: composer install

@alexmigf alexmigf marked this pull request as draft March 7, 2023 12:58
@alexmigf
Copy link
Member Author

alexmigf commented Mar 7, 2023

I notice some other issues, I need to fix those before your reviews.

@alexmigf alexmigf marked this pull request as ready for review March 7, 2023 14:11
@alexmigf
Copy link
Member Author

alexmigf commented Mar 7, 2023

@dwalkerpriv you could review now.

Copy link

@dwalkerpriv dwalkerpriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well on my end:

The invoice:
Screenshot 2023-03-08 054825

RTL
Screenshot 2023-03-08 055005

Packing Slip
Screenshot 2023-03-08 055814

RTL
Screenshot 2023-03-08 052849

The footer appears normally withe the "Simple" template as well.

With the Simple Premium (as well as the other premium templates), the footer appears like this:
Screenshot 2023-03-08 060319

@alexmigf
Copy link
Member Author

alexmigf commented Mar 8, 2023

@dwalkerpriv this PR just fixes the mPDF templates ( Simple mpdf and rtl), the others are on different repositories.

@dwalkerpriv dwalkerpriv self-requested a review March 8, 2023 11:40
@dpeyou
Copy link
Contributor

dpeyou commented Mar 16, 2023

When I do composer install after git pull, I get:
Fatal error: count(): Argument #1 ($value) must be of type Countable|array, null given

@alexmigf
Copy link
Member Author

I don't have any issues, please consider removing the directory and clone again.

@dpeyou
Copy link
Contributor

dpeyou commented Mar 17, 2023

@alexmigf I removed the directory and still get the same error.
Using composer 2.0.9

@alexmigf
Copy link
Member Author

alexmigf commented Mar 23, 2023

@dpeyou remove the directory, update composer to the last version (current 2.5.5) and do this:

git clone git@github.com:wpovernight/woocommerce-pdf-ips-mpdf.git
cd woocommerce-pdf-ips-mpdf
composer install

@dpeyou
Copy link
Contributor

dpeyou commented Mar 30, 2023

@alexmigf I'm afraid I'm unable to test mPDF. I download the latest binary as described on the composer website, to my home directory using:
php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" php -r "if (hash_file('sha384', 'composer-setup.php') === '55ce33d7678c5a611085589f1f3ddf8b3c52d662cd01d4ba75c0ee0459970c2200a51f492d557530c71c15d8dba01eae') { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;" php composer-setup.php php -r "unlink('composer-setup.php');"

....then I call the binary using /home/dtoo/composer.phar
Command: /home/dtoo/composer.phar -V
Result: Composer version 2.5.5 2023-03-21 11:50:05

So I did /home/dtoo/composer.phar install in the mPDF plugin directory, it installs the vendor file, but I still get the same error. :( :( :(

@dpeyou
Copy link
Contributor

dpeyou commented Mar 30, 2023

When tested in a new environment, it works properly...so I think I can approve the PR..?

@alexmigf
Copy link
Member Author

If you think so :)

Copy link
Contributor

@dpeyou dpeyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues encountered in a fresh install 👍
Footer sticks to bottom as in the other templates

Copy link

@YordanSoares YordanSoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ LGTM!

@alexmigf alexmigf merged commit be22265 into main Apr 6, 2023
@alexmigf alexmigf deleted the 7-fix-mpdf-templates-sticky-footer-bottom branch April 6, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move footer to bottom of page by default
4 participants