Allow plugins to define default tabs, allow users to create a new layout without restarting the app #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents some issues with sources being created ahead-of-time by the autopopulation the default tabs, which would then be overwritten by the tabs from the save file.
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
============================================
- Coverage 29.85% 29.72% -0.14%
- Complexity 661 665 +4
============================================
Files 222 224 +2
Lines 6132 6203 +71
Branches 484 492 +8
============================================
+ Hits 1831 1844 +13
- Misses 4178 4235 +57
- Partials 123 124 +1 |
This was referenced Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes startup a bit to load the default tabs only after attempting to load the last save file. Previously, the default tabs were loaded first, then overwritten with the new ones. The old tabs would also perform autopopulation and source caching, which isn't something we should do before we have to