General housekeeping cleanup #306

SamCarlberg · 2017-11-21T21:18:13Z

Fixes lots of minor issues:

Also improves performance of previewing tiles from dropped sources by caching the size rather than creating and computing the size of a new widget/layout EVERY time the mouse is moved while dragging

Fixes wpilibsuite#142 Fixes wpilibsuite#264 Fixes wpilibsuite#272

Replaces most instances of "Smartdashboard" to "Shuffleboard", except for the Smartdashboard tab since that contains stuff in the Smartdashboard table from the robot Fixes wpilibsuite#44

Fixes wpilibsuite#127

Also improves performance of previewing tiles from dropped sources by caching the size of the widget rather than creating a new widget/layout EVERY time the mouse is moved while dragging Fixes wpilibsuite#115

Fixes wpilibsuite#221

Fixes wpilibsuite#270 Adds a few helper methods to Registry to register collections of items and a non-throwing registerIfAbsent() method

nightpool · 2017-11-22T17:50:14Z

What's going on with SendableChooserAdapter here? seems to have disappeared?

SamCarlberg · 2017-11-22T19:38:15Z

It was unused so it was removed. Serializers for FRC data types should be all-or-nothing; having just one adapter for one data type out of many just isn't good. It implies that we support serializing FRC data not from NetworkTables, which we don't

JLLeitschuh · 2017-11-22T19:47:23Z

api/src/main/java/edu/wpi/first/shuffleboard/api/data/DataTypes.java

+/**
+ * Registry of data types in shuffleboard. This class also provides data types for various "wildcard" types, as well as
+ * types for primitive and arrays of primitive data. These types are always registered and may not be unregistered.
+ */
 public class DataTypes extends Registry<DataType> {

  // TODO replace with DI eg Guice
  private static DataTypes defaultInstance = null;

  // Catchall or wildcard types


That's just an alternate spelling.

JLLeitschuh · 2017-11-22T19:47:43Z

api/src/main/java/edu/wpi/first/shuffleboard/api/data/DataTypes.java

+   * The default data types. None of these may be unregistered.
+   */
+  private static final ImmutableCollection<DataType<?>> defaultTypes = ImmutableSet.of(
+      // catchall


JLLeitschuh · 2017-11-22T19:48:38Z

...rc/main/java/edu/wpi/first/shuffleboard/api/sources/recording/serialization/Serializers.java

@@ -17,6 +19,16 @@

  static {
    Runtime.getRuntime().addShutdownHook(new Thread(Serializers::cleanUpAll));


At a high level, can you explain why this is necessary?

Cleans up serializers eg by closing file handles or finalizing recorded video files. Otherwise recorded video files would be unreadable

Fair enough. So this only works if the app fails "gracefully" then (instead of via force-quit).

JLLeitschuh · 2017-11-22T19:49:48Z

app/src/main/java/edu/wpi/first/shuffleboard/app/components/TilePane.java

@@ -409,6 +409,9 @@ public boolean isOverlapping(int col, int row, int tileWidth, int tileHeight, Pr
    return false;
  }

+  /**
+   * Gets the layout of a tile in this tile pane.


Gets or creates??

It computes the layout and stores it in a data object? It only "creates" a layout in the very narrow sense that a new data object is created to contain it

JLLeitschuh · 2017-11-22T19:51:10Z

app/src/main/java/edu/wpi/first/shuffleboard/app/dnd/ResizeUtils.java

+
+  public static final Predicate<Node> isResizedTile = n -> n instanceof Tile && isResizedTile((Tile) n);
+
+  private static final AtomicReference<Tile<?>> currentTile = new AtomicReference<>(null);


This seems a bit concerning. Why is this necessary?

It's so that the widget pane can ignore the tile being resized when previewing its layout. Otherwise the highlight would always be red/"invalid" instead of only when it intersects with another tile

Not a fan of this but I don't have a better solution that doesn't involve some sort of DI framework.

Eg. The GRIP Drag service: https://github.com/WPIRoboticsProjects/GRIP/blob/1c1a5f6faa310dfd82b576632c46f2e9e00dc728/ui/src/main/java/edu/wpi/grip/ui/dragging/DragService.java

JLLeitschuh · 2017-11-22T19:52:30Z

...u/wpi/first/shuffleboard/plugin/base/recording/serialization/SendableChooserAdapterTest.java

-import static org.junit.jupiter.api.Assertions.assertEquals;
-
-
-public class SendableChooserAdapterTest extends AbstractAdapterTest<SendableChooserData> {


Are you not supporting SenableChooser's anymore?

All data recording for FRC data types is currently done by the NetworkTableSourceType to reduce file size. See #306 (comment)

bradamiller · 2017-11-24T23:24:37Z

has merge conflicts

codecov-io · 2017-11-25T23:12:42Z

Codecov Report

Merging #306 into master will increase coverage by 1.16%.
The diff coverage is 32.25%.

@@             Coverage Diff              @@
##             master     #306      +/-   ##
============================================
+ Coverage     20.55%   21.72%   +1.16%     
- Complexity      434      464      +30     
============================================
  Files           203      203              
  Lines          5292     5334      +42     
  Branches        407      413       +6     
============================================
+ Hits           1088     1159      +71     
+ Misses         4141     4103      -38     
- Partials         63       72       +9

Lower minimum size to 32px Set minimum sizes for various widgets

FXML was missing the root ID tag Also add a sanity check to avoid similar regressions in the future

SamCarlberg added 5 commits November 21, 2017 12:52

Rename widget classes to end with "Widget", rename WidgetPropertySheet

6899dc6

Fixes wpilibsuite#142 Fixes wpilibsuite#264 Fixes wpilibsuite#272

Use ~/Shuffleboard instead of ~/Smartdashboard

dbdecdb

Replaces most instances of "Smartdashboard" to "Shuffleboard", except for the Smartdashboard tab since that contains stuff in the Smartdashboard table from the robot Fixes wpilibsuite#44

Show grid highlight when resizing tiles

9a4d5a9

Fixes wpilibsuite#127

Preview size of dropped widgets from the gallery

72df8d4

Also improves performance of previewing tiles from dropped sources by caching the size of the widget rather than creating a new widget/layout EVERY time the mouse is moved while dragging Fixes wpilibsuite#115

Set text overrun of layout labels to be leading ellipsis

8bce86f

Fixes wpilibsuite#221

SamCarlberg added bugfix Fixes one or more bugs housekeeping labels Nov 21, 2017

Move primitive data types and adapters to API module

5004419

Fixes wpilibsuite#270 Adds a few helper methods to Registry to register collections of items and a non-throwing registerIfAbsent() method

JLLeitschuh reviewed Nov 22, 2017

View reviewed changes

Merge branch 'master' into housekeeping

6c316ef

SamCarlberg added 2 commits November 25, 2017 19:56

Enforce minimum tile size

32fe094

Lower minimum size to 32px Set minimum sizes for various widgets

Fix SpeedControllerWidget

f1bfbe0

FXML was missing the root ID tag Also add a sanity check to avoid similar regressions in the future

SamCarlberg mentioned this pull request Nov 29, 2017

Save tile size, hgap, and vgap #303

Merged

Disable god class check on TilePane, fix WidgetSaverTest NPE

c1bb77a

bradamiller approved these changes Dec 21, 2017

View reviewed changes

bradamiller merged commit ead9bfb into wpilibsuite:master Dec 21, 2017

SamCarlberg deleted the housekeeping branch December 21, 2017 20:49

SamCarlberg mentioned this pull request Jan 4, 2018

Tile Size should validate for proper input #131

Closed

SamCarlberg mentioned this pull request Jan 29, 2018

Problem with resizing text fields #203

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General housekeeping cleanup #306

General housekeeping cleanup #306

SamCarlberg commented Nov 21, 2017

nightpool commented Nov 22, 2017

SamCarlberg commented Nov 22, 2017

JLLeitschuh Nov 22, 2017 •

edited

Loading

SamCarlberg Nov 22, 2017

JLLeitschuh Nov 22, 2017

JLLeitschuh Nov 22, 2017

SamCarlberg Nov 22, 2017

JLLeitschuh Nov 22, 2017

JLLeitschuh Nov 22, 2017

SamCarlberg Nov 22, 2017

JLLeitschuh Nov 22, 2017

SamCarlberg Nov 22, 2017

JLLeitschuh Dec 21, 2017

JLLeitschuh Nov 22, 2017

SamCarlberg Nov 22, 2017

bradamiller commented Nov 24, 2017

codecov-io commented Nov 25, 2017

		@@ -17,6 +19,16 @@

		static {
		Runtime.getRuntime().addShutdownHook(new Thread(Serializers::cleanUpAll));


		public static final Predicate<Node> isResizedTile = n -> n instanceof Tile && isResizedTile((Tile) n);

		private static final AtomicReference<Tile<?>> currentTile = new AtomicReference<>(null);

		import static org.junit.jupiter.api.Assertions.assertEquals;


		public class SendableChooserAdapterTest extends AbstractAdapterTest<SendableChooserData> {

General housekeeping cleanup #306

General housekeeping cleanup #306

Conversation

SamCarlberg commented Nov 21, 2017

nightpool commented Nov 22, 2017

SamCarlberg commented Nov 22, 2017

JLLeitschuh Nov 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bradamiller commented Nov 24, 2017

codecov-io commented Nov 25, 2017

Codecov Report

JLLeitschuh Nov 22, 2017 •

edited

Loading