Skip to content

Conversation

@jasondaming
Copy link
Member

Closes #958

@Daltz333 Daltz333 changed the title changed from drive to flywheel Change ComandBased Example to Flywheel Nov 30, 2020
Copy link
Member

@prateekma prateekma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although motor safety is not enabled by default on individual motors, we should a note mentioning that this will not work if teams have explicitly enabled it.

@jasondaming
Copy link
Member Author

I feel like if you know enough to enable motor safety then you know much more than this example is aimed at. This is not true of motor safety for drive as that is enabled by default and this could be used with true understanding of why motor safety would prevent it from running.

What causes this command to stop? I think this is true of a couple of examples in the code but I don't think that this code makes sense completely. We just have to weigh is it worth adding a decorator to increase the usefulness of the code while making it slightly more complex? I am seriously tempted to add a .timeout so it actually has a reason to stop, thoughts?

@AustinShalit AustinShalit merged commit 5dfc260 into wpilibsuite:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct StartEndCommand example

4 participants