Skip to content

Conversation

@jasondaming
Copy link
Member

No description provided.

@jasondaming
Copy link
Member Author

Fixes #946

Not sure why link check is failing. Do I need to add images I moved to the redirects.txt? I ran .\make linkcheck on my computer.

@sciencewhiz
Copy link
Collaborator

It's failing this line: docs/networking/networking-introduction/roborio-network-troubleshooting.rst:16 Specifically, for a ref link you need to include the section. You can either include the first section title, or change to a doc link.

@sciencewhiz
Copy link
Collaborator

As requested in the beta forums, I think it's important to understand what adapters you had that might lead to understanding the reason why disabling adapters worked for you. It's known why the radio tool needs that, but not the imaging tool. If it's something that NI can fix, then we don't have to document a workaround.

jasondaming and others added 4 commits November 22, 2020 21:16
…-troubleshooting.rst

Co-authored-by: Dalton Smith <daltzsmith@gmail.com>
…-troubleshooting.rst

Co-authored-by: Dalton Smith <daltzsmith@gmail.com>
…-troubleshooting.rst

Co-authored-by: Dalton Smith <daltzsmith@gmail.com>
@jasondaming
Copy link
Member Author

As requested in the beta forums, I think it's important to understand what adapters you had that might lead to understanding the reason why disabling adapters worked for you. It's known why the radio tool needs that, but not the imaging tool. If it's something that NI can fix, then we don't have to document a workaround.

I will follow up on the forums and we will get to the bottom of it and include whatever the conclusion is.

@jasondaming jasondaming requested a review from Daltz333 November 30, 2020 15:22
@Daltz333
Copy link
Member

Was the root issue fixed?

@jasondaming
Copy link
Member Author

I have worked with them on Team Forge. I think it is hard to prove that my issue was solved by this without more testers. Either way for now I think this is a good suggested step to take and this PR helps clean up that article and the structure.

@Daltz333
Copy link
Member

Daltz333 commented Dec 2, 2020

I think that's fine.

@Daltz333 Daltz333 merged commit baa1466 into wpilibsuite:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants