Add usage reporting for dashboards as instances #7294
Conversation
Detects dashboards based on network tables client identity Depends on wpilibsuite#7293 to detect SmartDashboard
sciencewhiz
added
attn: NI
component: usage reporting
| } else { | ||
| // Only report unknown if there wasn't another dashboard already reported | ||
| // (unknown could also be another device) | ||
| if (!m_detected) { |
There was a problem hiding this comment.
This would likely report a coprocessor as an unknown dashboard before a DS laptop connects, right? I presume we're okay with that, just calling it out.
There was a problem hiding this comment.
Yes, but if a dashboard connected later, it would override the unknown. I just didn't want the unknown to override something known.
|
I'm a big fan of this PR, there's one concerning change that I want to let you know about. Within the next update for Elastic I'm going to change the client identity from "elastic" to "Elastic". To prevent this from causing it to be reported as unknown there should be some sort of case-insensitive check or add |
sciencewhiz
force-pushed
the
DashBoardUsage
branch
from
294ae10
to
690234e
Compare
sciencewhiz
force-pushed
the
DashBoardUsage
branch
from
254530b
to
de55257
Compare
Detects dashboards based on network tables client identity
Depends on #7293 to detect SmartDashboard