Skip to content

PHP Compat Revamp #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
122 commits
Select commit Hold shift + click to select a range
a47d5dc
Ignore vscode logs
cadic Jun 27, 2022
56be92c
Composer allow plugins
cadic Jun 27, 2022
960fc65
Composer update lockfile
cadic Jun 27, 2022
b2a8d00
Drop Node to 14
cadic Jun 27, 2022
c396f60
package-lock.json
cadic Jun 27, 2022
f84f82b
Merge pull request #1 from 10up/update-dependencies
cadic Jun 28, 2022
438fa9b
Test exclude plugin
cadic Jun 28, 2022
8d1016b
Function to get list of plugins with slugs
cadic Jun 28, 2022
4503e9c
Deprecation notices
cadic Jun 28, 2022
6088411
Apply filters on plugins
cadic Jun 28, 2022
dbbe7d5
Compact output for plugins
cadic Jun 28, 2022
6b349ab
Function to get list of themes
cadic Jun 28, 2022
253dfed
Remove deprecated function related to directories
cadic Jun 28, 2022
ddacf6d
Rename functions
cadic Jun 28, 2022
ef8d3cb
Remove deprecated function
cadic Jun 28, 2022
fe0f601
Minor formatting and text updates
dkotter Jun 28, 2022
589a2dd
Remove loadtextdomain
cadic Jun 29, 2022
60037a1
Conditional check for empty plugins list
cadic Jun 29, 2022
8049f27
Fix legacy tests
cadic Jun 29, 2022
7755905
Docblocks
cadic Jun 29, 2022
dc9d63b
sanitize
cadic Jun 29, 2022
8513e45
AJAX queue with debug output
cadic Jun 29, 2022
5c7950e
Enqueue new JS file
cadic Jun 29, 2022
c76cac7
Comments
cadic Jun 29, 2022
09dc767
Minor formatting and text updates
dkotter Jun 29, 2022
e817d6d
Move phpcompat_excluded_plugins filter into main function
cadic Jun 30, 2022
bbda310
Add phpcompat_excluded_themes filter
cadic Jun 30, 2022
6986bc4
Advanced console output
cadic Jun 30, 2022
4ec32e7
Fix formatting
cadic Jun 30, 2022
a102030
Remove exclude_plugin method and tests
cadic Jun 30, 2022
8369e22
Rename activeOnly variable
cadic Jun 30, 2022
4e9a2e9
Merge pull request #2 from 10up/list-directories_ENG-2
dkotter Jun 30, 2022
d044a11
Merge branch 'feat/phpcompat-revamp' into ajax-request_ENG-3
cadic Jun 30, 2022
7cdf25b
Refactor JS sources and build scripts
cadic Jul 1, 2022
411b8ac
Watch make command
cadic Jul 1, 2022
9f79e9a
Render
cadic Jul 1, 2022
a61d97a
Remove PHP Versions select
cadic Jul 1, 2022
26221ad
Remove old assets
cadic Jul 1, 2022
50a52d9
Handle unknown errors
cadic Jul 1, 2022
626f064
Truncate queue on init
cadic Jul 1, 2022
7052edc
Cleanup and comments
cadic Jul 1, 2022
9147e65
Avoid long if/else
cadic Jul 4, 2022
99bb046
Remove todo 'indicate in progress'
cadic Jul 4, 2022
d9a1968
Todo change staging endpoint
cadic Jul 4, 2022
c30d3c0
JS Code formatting, remove debug console output
cadic Jul 4, 2022
30409dd
Add translations to JS, change the makepot command
cadic Jul 4, 2022
117ddb6
Remove gulp config
cadic Jul 4, 2022
0c0f750
Change admin page slug and remove version constant
cadic Jul 4, 2022
234fab0
Change textdomain
cadic Jul 4, 2022
c94198f
Remove gulp deps
cadic Jul 4, 2022
e84dd04
Update limitations text, fix textdomain
cadic Jul 4, 2022
509ecbe
Add escaping to translations
cadic Jul 4, 2022
70d4673
Abort process on change of active/all target
cadic Jul 4, 2022
7cc5956
Display PHPCS-like details, add 'view results as raw text' checkbox
cadic Jul 4, 2022
160bb53
Download button
cadic Jul 4, 2022
65d6bcb
Download section styles, clear results
cadic Jul 5, 2022
882741c
Handle plugins outside of WP repository
cadic Jul 5, 2022
4a77c84
Merge pull request #4 from 10up/limitations_ENG-5
dkotter Jul 5, 2022
5c579f4
Merge branch 'feat/phpcompat-revamp' into ajax-request_ENG-3
dkotter Jul 5, 2022
5d6b6cb
Merge pull request #3 from 10up/ajax-request_ENG-3
dkotter Jul 5, 2022
7de59fb
Change 'test this site' link to LocalWP
cadic Jul 8, 2022
39cabde
Remove unused code
cadic Jul 8, 2022
d5627ef
Use is_wpe()
cadic Jul 8, 2022
6a60cd6
Clean legacy data during activate and uninstall
cadic Jul 8, 2022
ac0607e
Cleanup during plugin upgrade
cadic Jul 8, 2022
f2bbbd5
Code styles
cadic Jul 8, 2022
8964664
Aside styles
cadic Jul 8, 2022
1f9978c
Update codeable form with scan report
cadic Jul 8, 2022
a81cc90
Lint
cadic Jul 8, 2022
9b8bc03
Merge pull request #5 from 10up/test-link_ENG-6
dkotter Jul 8, 2022
7bf7e6c
Remove code comments
dkotter Jul 8, 2022
fbaa197
Merge pull request #7 from 10up/aside
dkotter Jul 8, 2022
bc6759a
migration improvements
cadic Jul 11, 2022
7117e20
Merge branch 'feat/phpcompat-revamp' into cleanup
cadic Jul 11, 2022
b5ed52b
Merge pull request #6 from 10up/cleanup
dkotter Jul 11, 2022
f5b43f5
Minor formatting and text updates
dkotter Jul 12, 2022
ec5d270
Disable scan button during the scan
cadic Jul 13, 2022
8560b09
lint
cadic Jul 13, 2022
a3a4f10
Ignore wp-env local config
cadic Jul 13, 2022
58d4b3b
Unified error reporting
cadic Jul 13, 2022
ea271f9
Extended error reporting
cadic Jul 13, 2022
10082a3
Close report clicking on the version or link
cadic Jul 13, 2022
7c4afa7
Merge pull request #8 from 10up/minor-tweaks
dkotter Jul 13, 2022
cb794f3
Update title and clean up
cadic Jul 13, 2022
1659ad8
Add all PHP versions to the raw report
cadic Jul 13, 2022
746df52
Merge pull request #10 from 10up/error-reports
dkotter Jul 13, 2022
70af4b9
Add errors to raw report
cadic Jul 13, 2022
6db5a5c
Merge branch 'feat/phpcompat-revamp' into raw-report
cadic Jul 13, 2022
7529754
Merge pull request #11 from 10up/report-collapse
dkotter Jul 13, 2022
9b4a14c
Merge pull request #12 from 10up/report-title
dkotter Jul 13, 2022
fb5eafd
Remove string that was left behind
dkotter Jul 13, 2022
c9a6bea
Change how we sanitize slugs to ensure they have no spaces
dkotter Jul 13, 2022
38142e8
Fix mixing full report with single version report
cadic Jul 13, 2022
b7bc5d4
lint
cadic Jul 13, 2022
7c8e92d
shortcut runButton
cadic Jul 13, 2022
7274c37
Merge pull request #9 from 10up/scan-button-behaviour
dkotter Jul 13, 2022
251cc00
Merge pull request #13 from 10up/raw-report
dkotter Jul 13, 2022
c30d7b9
If we get a success response back from the Tide API but that response…
dkotter Jul 13, 2022
40c1519
Update src/js/include/render.js
dkotter Jul 14, 2022
1e1af2d
Merge pull request #14 from 10up/fix/no-report
dkotter Jul 14, 2022
79b210b
Version bump and plugin header
cadic Jul 15, 2022
11c06c5
Fix
cadic Jul 15, 2022
4724a5a
Reset to normal state when results are cleared
cadic Jul 15, 2022
0f0d6ef
Add Start Scan link
cadic Jul 15, 2022
abd8359
fix
cadic Jul 15, 2022
03e4e87
Merge pull request #15 from 10up/plugin-header
dkotter Jul 15, 2022
f5c005a
Merge pull request #16 from 10up/fix-reset
dkotter Jul 15, 2022
5860158
Merge pull request #17 from 10up/plugin-links
dkotter Jul 15, 2022
432dc75
add back missing readme.txt file
jeffpaul Jul 15, 2022
2bb4499
formatting updates to readme.txt
jeffpaul Jul 15, 2022
31874ef
cleanup plugin header fields
jeffpaul Jul 15, 2022
8153b92
updated readme.txt content for 1.6.0 version
jeffpaul Jul 15, 2022
3a250d2
Merge pull request #18 from 10up/add/readme-txt
dkotter Jul 15, 2022
434484b
Text update
dkotter Jul 15, 2022
6f9e8e0
Merge branch 'feat/phpcompat-revamp' of github.com:10up/phpcompat int…
dkotter Jul 18, 2022
0d12f9a
update LocalWP and PHP 7 text references
jeffpaul Jul 18, 2022
f6404d3
Avoid a fatal error if the plugin isn't built properly
dkotter Jul 18, 2022
5039bc5
Ensure we only load our assets on the scan page
dkotter Jul 18, 2022
02cf280
If connection is lost during the middle of the scan, show proper erro…
dkotter Jul 18, 2022
6d18705
If on multisite, make sure we include network active plugins in our l…
dkotter Jul 20, 2022
d218630
Add RTL styling
dkotter Jul 20, 2022
d07af24
Add a progress indicator at the top of the scan page to make it easie…
dkotter Jul 21, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ assets/js/*.js
assets/js/*.map
coverage.clover
/plugin/scripts/*-min.js
/plugin/build/
wpe-php-compat.zip
.phpunit.result.cache

Expand All @@ -222,3 +223,7 @@ Docker/debug
# Build files
/build/
clover.xml

.vscode/*.log

.wp-env.override.json
1 change: 1 addition & 0 deletions .jshintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
gulpfile.js
**/*-min.js
plugin/build/
wordpress/
node_modules/
vendor/
2 changes: 1 addition & 1 deletion Docker/Dockerfile-node
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:lts
FROM node:14
ARG UID=1000
ARG GID=1000

Expand Down
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ END_HIGHLIGHT :=\033[0m # No Color
build: build-docker build-assets

.PHONY: build-assets
build-assets: | build-docker-node install-npm
build-assets: | build-docker-node install-npm install-composer
@echo "Building plugin assets"
rm -f plugin/languages/*.pot plugin/scripts/*-min.js
$(DOCKER_RUN) $(NODE_IMAGE) ./node_modules/gulp-cli/bin/gulp.js
$(DOCKER_RUN) $(NODE_IMAGE) npm run build
$(DOCKER_RUN) $(COMPOSER_BASE_CONTAINER) run-script makepot

.PHONY: build-docker
build-docker: build-docker-node build-docker-php
Expand Down Expand Up @@ -160,6 +161,10 @@ update-composer: lando-stop
update-npm: | build-docker-node
$(DOCKER_RUN) $(NODE_IMAGE) npm update

.PHONY: watch
watch: | build-docker-node install-npm
$(DOCKER_RUN) $(NODE_IMAGE) npm run start

wpe-php-compat.zip:
@echo "Building release file: wpe-php-compat.zip"
rm -f wpe-php-compat.zip
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ __URL:__ _http://localhost:8888/wp-admin_

__Admin User:__ _admin_

__Admin Password:__ _password

After you have logged in, go to http://localhost:8888/wp-admin/admin.php?page=fakerpress and generate some dummy content for the block to render.
__Admin Password:__ _password_

If anything goes wrong and you suspect your local is frozen, you can always `make choose-violence` to rebuild the local environment and containers. Hopefully you never have to choose violence. :)

Expand Down
10 changes: 10 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,17 @@
"phpunit/phpunit": "^9.5.4",
"brain/monkey": "^2.6.0",
"dealerdirect/phpcodesniffer-composer-installer": "^v0.7.1",
"wp-cli/wp-cli-bundle": "*",
"wpengine/wpengine-coding-standards": "^1.0.0",
"johnpbloch/wordpress": "*"
},
"config": {
"allow-plugins": {
"johnpbloch/wordpress-core-installer": true,
"dealerdirect/phpcodesniffer-composer-installer": true
}
},
"scripts": {
"makepot": "./vendor/bin/wp i18n make-pot plugin --slug=wpe-php-compat"
}
}
Loading