-
Notifications
You must be signed in to change notification settings - Fork 2
chore(previews): test against WordPress 6.9 #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Verified compatibility with WordPress 6.9 and updated the CI test matrix to include WordPress 6.9, 6.8, and 6.7 (removing 6.5 and 6.6). Updated development dependencies: mockery/mockery to ^1.6 and wp-graphql/wp-graphql-testcase to ^3.4. Removed GitHub Plugin URI and Update URI headers for WordPress.org compatibility and reduced readme.txt tags to five for compliance. Updated .wp-env.json to use the latest WordPress core. Refreshed composer dependencies, including a major update to lucatume/wp-browser and related packages.
🦋 Changeset detectedLatest commit: b0f7b96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Plugin Artifacts Ready!Download from GitHub Actions run Available plugins:
See the "Artifacts" section at the bottom of the Actions run page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the hwp-previews plugin to support WordPress 6.9 by updating compatibility metadata and modernizing the testing infrastructure.
- Updated "Tested up to" metadata from WordPress 6.8.1 to 6.9 across plugin files
- Modernized dev dependencies (mockery/mockery to ^1.6, wp-graphql/wp-graphql-testcase to ^3.4)
- Updated CI test matrix to cover WordPress 6.9, 6.8, and 6.7 (removing 6.5 and 6.6)
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/hwp-previews/readme.txt | Updated WordPress compatibility to 6.9 and simplified tags for WordPress.org compliance |
| plugins/hwp-previews/hwp-previews.php | Updated "Tested up to" header to WordPress 6.9 |
| plugins/hwp-previews/composer.json | Bumped mockery and wp-graphql-testcase dev dependencies to newer versions |
| .github/workflows/codeception.yml | Updated CI matrix to test against WordPress 6.9, 6.8, 6.7 and set 6.9 for coverage testing |
| .changeset/prepare-public-release.md | Added changeset documenting WordPress 6.9 compatibility updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The CI integration tests were failing because composer.lock was out of sync with composer.json. The root cause was phpcompatibility/php-compatibility using "dev-develop as 9.99.99" which requires PHPCS 4.x, conflicting with automattic/vipwpcs ^3.0 which requires PHPCS 3.x. Changes: - Pin phpcompatibility/php-compatibility to stable ^9.3 - Regenerate composer.lock with compatible dependencies - Add native type hints to properties flagged by updated coding standards
The wordpress-stubs v6.8+ package contains PHP 8+ syntax in stub files, which causes parse errors when PHPStan runs on PHP 7.4. PHPStan can analyze PHP 7.4-compatible code while running on PHP 8.x, so this change updates the CI workflow to use PHP 8.2 for all code quality checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Revert typed property changes to keep PR focused on WP 6.9 compat - Remove inaccurate changeset claim about header removal
This PR prepares the hwp-previews plugin for WordPress 6.9 compatibility.