Skip to content

Conversation

@josephfusco
Copy link
Member

@josephfusco josephfusco commented Dec 2, 2025

This PR prepares the hwp-previews plugin for WordPress 6.9 compatibility.

Verified compatibility with WordPress 6.9 and updated the CI test matrix to include WordPress 6.9, 6.8, and 6.7 (removing 6.5 and 6.6). Updated development dependencies: mockery/mockery to ^1.6 and wp-graphql/wp-graphql-testcase to ^3.4. Removed GitHub Plugin URI and Update URI headers for WordPress.org compatibility and reduced readme.txt tags to five for compliance. Updated .wp-env.json to use the latest WordPress core. Refreshed composer dependencies, including a major update to lucatume/wp-browser and related packages.
@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2025

🦋 Changeset detected

Latest commit: b0f7b96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/hwp-previews-wordpress-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

📦 Plugin Artifacts Ready!

Download from GitHub Actions run

Available plugins:

  • ✅ hwp-previews.zip

See the "Artifacts" section at the bottom of the Actions run page

@josephfusco josephfusco changed the title Issue 488 hwp previews review chore: test hwp-previews against WordPress 6.9 Dec 2, 2025
@josephfusco josephfusco requested a review from Copilot December 2, 2025 19:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the hwp-previews plugin to support WordPress 6.9 by updating compatibility metadata and modernizing the testing infrastructure.

  • Updated "Tested up to" metadata from WordPress 6.8.1 to 6.9 across plugin files
  • Modernized dev dependencies (mockery/mockery to ^1.6, wp-graphql/wp-graphql-testcase to ^3.4)
  • Updated CI test matrix to cover WordPress 6.9, 6.8, and 6.7 (removing 6.5 and 6.6)

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
plugins/hwp-previews/readme.txt Updated WordPress compatibility to 6.9 and simplified tags for WordPress.org compliance
plugins/hwp-previews/hwp-previews.php Updated "Tested up to" header to WordPress 6.9
plugins/hwp-previews/composer.json Bumped mockery and wp-graphql-testcase dev dependencies to newer versions
.github/workflows/codeception.yml Updated CI matrix to test against WordPress 6.9, 6.8, 6.7 and set 6.9 for coverage testing
.changeset/prepare-public-release.md Added changeset documenting WordPress 6.9 compatibility updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The CI integration tests were failing because composer.lock was out of
sync with composer.json. The root cause was phpcompatibility/php-compatibility
using "dev-develop as 9.99.99" which requires PHPCS 4.x, conflicting with
automattic/vipwpcs ^3.0 which requires PHPCS 3.x.

Changes:
- Pin phpcompatibility/php-compatibility to stable ^9.3
- Regenerate composer.lock with compatible dependencies
- Add native type hints to properties flagged by updated coding standards
The wordpress-stubs v6.8+ package contains PHP 8+ syntax in stub files,
which causes parse errors when PHPStan runs on PHP 7.4. PHPStan can
analyze PHP 7.4-compatible code while running on PHP 8.x, so this change
updates the CI workflow to use PHP 8.2 for all code quality checks.
@josephfusco josephfusco requested a review from Copilot December 2, 2025 20:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@josephfusco josephfusco changed the title chore: test hwp-previews against WordPress 6.9 chore: [hwp-previews] test against WordPress 6.9 Dec 2, 2025
@josephfusco josephfusco changed the title chore: [hwp-previews] test against WordPress 6.9 chore(previews): test against WordPress 6.9 Dec 3, 2025
@josephfusco josephfusco requested a review from Copilot December 3, 2025 12:13
@josephfusco josephfusco marked this pull request as ready for review December 3, 2025 12:13
@josephfusco josephfusco requested a review from a team as a code owner December 3, 2025 12:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Revert typed property changes to keep PR focused on WP 6.9 compat
- Remove inaccurate changeset claim about header removal
@josephfusco josephfusco enabled auto-merge December 4, 2025 21:38
@josephfusco josephfusco requested a review from ahuseyn December 4, 2025 21:40
@josephfusco josephfusco added this pull request to the merge queue Dec 5, 2025
Merged via the queue into main with commit 5281626 Dec 5, 2025
19 checks passed
@josephfusco josephfusco deleted the issue-488-hwp-previews-review branch December 5, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants